• Michelle Nguyen's avatar
    Fix cloud kuberesolver TLS bug · 2273b457
    Michelle Nguyen authored
    Summary:
    we recently updated grpc, which slightly changes how it uses Addresses (https://godoc.org/google.golang.org/grpc/resolver#Address)
    See: ServerName. it says that if serverName is not empty, that is the name it will use to authenticate with the TLS cert. kuberesolver, the package we're using to resolve kube addresses does not leave this field empty, but rather uses the pod-name, which fails the TLS check. instead, it should be setting this field as "".  patched the kuberesolver library to do that.
    
    Test Plan: ran cloud dev and made sure could login
    
    Reviewers: zasgar, philkuz, #engineering, nserrino
    
    Reviewed By: #engineering, nserrino
    
    Differential Revision: https://phab.corp.pixielabs.ai/D4890
    
    GitOrigin-RevId: fd5f2395c3a2fa5dc22e2d04c32520fe4539d1c0
    2273b457