This project is mirrored from https://gitee.com/NQL886/packer.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 13 Jan, 2021 2 commits
  2. 12 Jan, 2021 3 commits
  3. 11 Jan, 2021 5 commits
  4. 08 Jan, 2021 3 commits
    • Darwin Liu's avatar
      Add in a sanity check for valid vnc ports · 8ef4cfa0
      Darwin Liu authored
      Check to make sure that the max and min VNC ports be below 65535 in
      config.
      8ef4cfa0
    • Darwin Liu's avatar
    • Darwin Liu's avatar
      QEMU: Minor fix to VNC mapping parameters and output · 4f2e9117
      Darwin Liu authored
      * Set the QEMU builder vnc_port_min to have a minimum value of 5900,
        with updated documentation to explain why.
      
      * Changed output messages so that the correct port is listed in packer's
        messaging to the user.
      
      LONGER DESCRIPTION
      
      If vnc_min_port is set to anything above 5900, then packer will fail to
      connect via VNC to the QEMU instance. This is due to how QEMU parses
      the port for listening to VNC:
      
         host:d
                     TCP connections will only be allowed from host on
                     display d.  By convention the TCP port is 5900+d.
      
      Previously the calculation for the port was vncPort - VNCPortMin,
      however this will result in an incorrect port being displayed in
      packer's messages and potentially packer being unable to connect via VNC
      to the host.
      
      For example if vnc_port_min=5990 nad vnc_port_max=5999:
      
      ```
      Looking for available port between 5990 and 5999 on 0.0.0.0
      Found available port: 5996 on IP: 0.0.0.0
      Found available VNC port: 5996 on IP: 0.0.0.0
      [....]
      ==> Starting VM, booting disk image
           view the screen of the VM, connect via VNC without a password to
           vnc://0.0.0.0:6
      ```
      
      This will cause QEMU to set the listening port to 5906 while packer's
      VNC client is attempting to connect to 5996.
      
      I am a touch concerned as this commit undoes pull request #9905
      (specfically commit 7335695c), but I am also confused as to how he was
      able to get QEMU to get a VNC listening port below 5900, as examining
      QEMU's git history has shown that this behavior has been in since at
      least 2017, probably older.
      
      Hopefully the more explicit error messaging and documentation can make
      it clear why this is being undone.
      4f2e9117
  5. 07 Jan, 2021 7 commits
  6. 06 Jan, 2021 6 commits
  7. 04 Jan, 2021 5 commits
  8. 28 Dec, 2020 3 commits
  9. 27 Dec, 2020 1 commit
  10. 21 Dec, 2020 4 commits
  11. 18 Dec, 2020 1 commit