user avatar
consul/connect: avoid warn messages on connect proxy errors
James Rasell authored
When creating a TCP proxy bridge for Connect tasks, we are at the
mercy of either end for managing the connection state. For long
lived gRPC connections the proxy could reasonably expect to stay
open until the context was cancelled. For the HTTP connections used
by connect native tasks, we experience connection disconnects.
The proxy gets recreated as needed on follow up requests, however
we also emit a WARN log when the connection is broken. This PR
lowers the WARN to a TRACE, because these disconnects are to be
expected.

Ideally we would be able to proxy at the HTTP layer, however Consul
or the connect native task could be configured to expect mTLS, preventing
Nomad from MiTM the requests.

We also can't mange the proxy lifecycle more intelligently, because
we have no control over the HTTP client or server and how they wish
to manage connection state.

What we have now works, it's just noisy.

Fixes #10933
a946419a
Name Last commit Last update
..
allocdir limit bytes passed to http.DetectContentType (#10348)
allochealth e2e test for on_update service checks
allocrunner consul/connect: avoid warn messages on connect proxy errors
allocwatcher client/allocwatcher: fix dropped test error (#6592)
config client: disable cpuset cgroup managment if init fails
consul consul: plubming for specifying consul namespace in job/group
devicemanager Fix some errcheck errors (#9811)
dynamicplugins Add gosimple linter (#9590)
fingerprint env/aws: update ec2 cpu data
interfaces Populate alloc stats API with device stats
lib nit: code cleanup/organization
logmon Add gosimple linter (#9590)
pluginmanager CSI: Include MountOptions in capabilities sent to CSI for all RPCs
servers client: drop unused DC field from servers list
state Add gosimple linter (#9590)
stats deps: bump gopsutil to v3.21.2
structs remove generated files
taskenv client: interpolate meta blocks with task environment (#10876)
testutil client/ar: thread through cpuset manager
vaultclient Add gosimple linter (#9590)
acl.go Audit config, seams for enterprise audit features
acl_test.go Event Stream: Track ACL changes, unsubscribe on invalidating changes (#9447)
agent_endpoint.go json handles were moved to a new package in #10202
agent_endpoint_test.go fix params for Agent.Host client RPC (#8795)
alloc_endpoint.go client: fix multiple imports (#10537)
alloc_endpoint_test.go
alloc_watcher_e2e_test.go
client.go
client_stats_endpoint.go
client_stats_endpoint_test.go
client_test.go
csi_endpoint.go
csi_endpoint_test.go
driver_manager_test.go
enterprise_client_oss.go
fingerprint_manager.go
fingerprint_manager_test.go
fs_endpoint.go
fs_endpoint_test.go
gc.go
gc_test.go
heartbeatstop.go
heartbeatstop_test.go
node_updater.go
rpc.go
rpc_test.go
testing.go
util.go
util_test.go