This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

The plugin manager for CSI hands out instances of a plugin for callers
that need to mount a volume. The `MounterForPlugin` method accesses
the internal instances map without a lock, and can be called
concurrently from outside the plugin manager's main run-loop.

The original commit for the instances map included a warning that it
needed to be accessed only from the main loop but that comment was
unfortunately ignored shortly thereafter, so this bug has existed in
the code for a couple years without being detected until we ran tests
with `-race` in #12098. Lesson learned here: comments make for lousy
enforcement of invariants!

The volume watcher design was based on deploymentwatcher and drainer,
but has an important difference: we don't want to maintain a goroutine
for the lifetime of the volume. So we stop the volumewatcher goroutine
for a volume when that volume has no more claims to free. But the
shutdown races with updates on the parent goroutine, and it's possible
to drop updates. Fortunately these updates are picked up on the next
core GC job, but we're most likely to hit this race when we're
replacing an allocation and that's the time we least want to wait.

Wait until the volume has "settled" before stopping this goroutine so
that the race between shutdown and the parent goroutine sending on
`<-updateCh` is pushed to after the window we most care about quick
freeing of claims.

* Fixes a resource leak when volumewatchers are no longer needed. The
  volume is nil and can't ever be started again, so the volume's
  `watcher` should be removed from the top-level `Watcher`.

* De-flakes the GC job test: the test throws an error because the
  claimed node doesn't exist and is unreachable. This flaked instead of
  failed because we didn't correctly wait for the first pass through the
  volumewatcher.

  Make the GC job wait for the volumewatcher to reach the quiescent
  timeout window state before running the GC eval under test, so that
  we're sure the GC job's work isn't being picked up by processing one
  of the earlier claims. Update the claims used so that we're sure the
  GC pass won't hit a node unpublish error.

* Adds trace logging to unpublish operations

This pull request was automerged via backport-assistant

Merge pull request #12696 from hashicorp/backport/docs-remove-deprecated-client-options/officially-enough-lemming

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

Listing snapshots was incorrectly returning nanoseconds instead of
seconds, and formatting of timestamps both list and create snapshot
was treating the timestamp as though it were nanoseconds instead of
seconds. This resulted in create timestamps always being displayed as
zero values.

Fix the unit conversion error in the command line and the incorrect
extraction in the CSI plugin client code. Beef up the unit tests to
make sure this code is actually exercised.

When a node is garbage collected, we assume that the volume is no
longer attached to it and ignore the `ErrUnknownNode` error. But we
used `errors.Is` to check for a wrapped error, and RPC flattens the
errors during serialization. This results in an error check that works
in automated testing but not in real clusters. Use a string contains
check instead.

A volume that has single-use access mode is feasibility checked during
scheduling to ensure that only a single reader or writer claim
exists. However, because feasibility checking is done one alloc at a
time before the plan is written, a job that's misconfigured to have
count > 1 that mounts one of these volumes will pass feasibility
checking.

Enforce the check at validation time instead to prevent us from even
trying to evaluation a job that's misconfigured this way.

Co-authored-by: Thomas Lefebvre <tlefebvre@cloudflare.com>

This pull request was automerged via backport-assistant

The RPC for listing volume snapshots requires a plugin ID. Update the
`volume snapshot list` command to find the specific plugin from the
provided prefix.

This reverts commit 1ffdda06.

Merge pull request #12677 from hashicorp/backport/csi-api-plugin-arg-for-snapshot/commonly-living-cockatoo

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

The Prestart hook for task runner hooks doesn't get called when we
restore a task, because the task is already running. The Postrun hook
for CSI plugin supervisors needs the socket path to have been
populated so that the client has a valid path.

Merge pull request #12663 from hashicorp/backport/csi-map-plugin-info-responses/positively-divine-cowbird

This pull request was automerged via backport-assistant

Merge pull request #12662 from hashicorp/backport/csi-tolerate-nil-plugin-on-job-delete/grossly-driving-dog

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

Merge pull request #12648 from hashicorp/backport/csi-enforce-usage-at-claim-time/specially-simple-swine

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

This pull request was automerged via backport-assistant

Merge pull request #12628 from hashicorp/backport/csi-plugin-expected-counts/currently-beloved-terrier

This pull request was automerged via backport-assistant

Merge pull request #12626 from hashicorp/backport/fix-rpc-tls-certificate-check/admittedly-precise-anteater

This pull request was automerged via backport-assistant