Skip to content
GitLab
Switch branch/tag
This project is mirrored from https://gitee.com/mirrors/nomad.git. Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
  1. 26 Sep, 2022 8 commits
  3. 23 Sep, 2022 3 commits
    • Phil Renaud's avatar
      [ui] Warn users when they leave an edited but unsaved variable page (#14665) · a34c241f
      Phil Renaud authored 
      * Warning on attempt to leave

* Lintfix

* Only router.off once

* Dont warn on transition when only updating queryparams

* Remove double-push and queryparam-only issues, thanks @lgfa29

* Acceptance tests

* Changelog
      a34c241f
    • Phil Renaud's avatar
      [ui] Service Healthchecks: styles for pseudo-timestamp axis (#14677) · 63098f1d
      Phil Renaud authored 
      * Styles for pseudo-timestamp axis

* Changelog
      63098f1d
    • Tim Gross's avatar
      fingerprint: don't clear Consul/Vault attributes on failure (#14673) · 786dc5ff
      Tim Gross authored 
      Clients periodically fingerprint Vault and Consul to ensure the server has
updated attributes in the client's fingerprint. If the client can't reach
Vault/Consul, the fingerprinter clears the attributes and requires a node
update. Although this seems like correct behavior so that we can detect
intentional removal of Vault/Consul access, it has two serious failure modes:

(1) If a local Consul agent is restarted to pick up configuration changes and the
client happens to fingerprint at that moment, the client will update its
fingerprint and result in evaluations for all its jobs and all the system jobs
in the cluster.

(2) If a client loses Vault connectivity, the same thing happens. But the
consequences are much worse in the Vault case because Vault is not run as a
local agent, so Vault connectivity failures are highly correlated across the
entire cluster. A 15 second Vault outage will cause a new `node-update`
evalution for every system job on the cluster times the number of nodes, plus
one `node-update` evaluation for every non-system job on each node. On large
clusters of 1000s of nodes, we've seen this create a large backlog of evaluations.

This changeset updates the fingerprinting behavior to keep the last fingerprint
if Consul or Vault queries fail. This prevents a storm of evaluations at the
cost of requiring a client restart if Consul or Vault is intentionally removed
from the client.
      786dc5ff
  5. 22 Sep, 2022 15 commits
  7. 21 Sep, 2022 3 commits
    • Seth Hoenig's avatar
      cleanup more helper updates (#14638) · ff1a30fe
      Seth Hoenig authored 
      * cleanup: refactor MapStringStringSliceValueSet to be cleaner

* cleanup: replace SliceStringToSet with actual set

* cleanup: replace SliceStringSubset with real set

* cleanup: replace SliceStringContains with slices.Contains

* cleanup: remove unused function SliceStringHasPrefix

* cleanup: fixup StringHasPrefixInSlice doc string

* cleanup: refactor SliceSetDisjoint to use real set

* cleanup: replace CompareSliceSetString with SliceSetEq

* cleanup: replace CompareMapStringString with maps.Equal

* cleanup: replace CopyMapStringString with CopyMap

* cleanup: replace CopyMapStringInterface with CopyMap

* cleanup: fixup more CopyMapStringString and CopyMapStringInt

* cleanup: replace CopySliceString with slices.Clone

* cleanup: remove unused CopySliceInt

* cleanup: refactor CopyMapStringSliceString to be generic as CopyMapOfSlice

* cleanup: replace CopyMap with maps.Clone

* cleanup: run go mod tidy
      ff1a30fe
    • Luiz Aoqui's avatar
      chore: move changelog file to the right folder (#14639) · 9e0987a8
      Luiz Aoqui authored
      9e0987a8
    • Luiz Aoqui's avatar
      api: provide more detail on ACL bootstrap request error (#14629) · ddeeb104
      Luiz Aoqui authored
      ddeeb104
  9. 19 Sep, 2022 2 commits
    • Luiz Aoqui's avatar
      Minor tweaks to the service views (#14619) · 54474a95
      Luiz Aoqui authored
      54474a95
    • Luiz Aoqui's avatar
      test: remove flaky Gate test (#14575) · a993931e
      Luiz Aoqui authored 
      The concurrent gate access test is flaky since it depends on the order
of operations of two concurrent goroutines. Despite the heavy bias
towards one of the results, it's still possible to end the execution
with a closed gate.

I believe this case was created to test an earlier implementation where
the gate state was stored and mutated internally, so the access had to
be protected by a lock. However, the final implementation changed this
approach to be only channel-based, so there is no need for this flaky
test anymore.
      a993931e
  11. 16 Sep, 2022 6 commits
  13. 15 Sep, 2022 3 commits

免费DevSecOps平台，让您的项目体验完整的DevSecOps流程，让项目更安全