This project is mirrored from https://gitee.com/mirrors/nomad.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 11 Jul, 2022 40 commits
-
-
Tim Gross authored
This changeset includes some additional unit tests for secure variables ACL policies, so that we have explicit coverage of edge cases we're discussing with the UI folks.
-
Tim Gross authored
Add fields for configuring root key garbage collection and automatic rotation. Fix the keystore path so that we write to a tempdir when in dev mode.
-
Phil Renaud authored
* JSON view init * Overeager config history reverted * Set as query parameter * border added to copy button * More robust stringifyObject helper * Testing for stringify-object helper
-
Jai authored
* ui: add logic for create permission computed property * ui: update token factory and variable ability to simulate create permissions for dev env
-
Phil Renaud authored
* Did-insert modifier to add an extra row when editing * Defensive logic on model existing * Defensive pattern on copy keyValues
-
Phil Renaud authored
* Error thrown if you have no KVs on save * Acceptance tests for flash messages and no-key-value adds * Post-hoc accounting for new variable path routing * Trim on key before validating it as existing
-
Tim Gross authored
Extend the GC job to support periodic key rotation. Update the GC process to safely support signed workload identity. We can't GC any key used to sign a workload identity. Finding which key was used to sign every allocation will be expensive, but there are not that many keys. This lets us take a conservative approach: find the oldest live allocation and ensure that we don't GC any key older than that key.
-
Tim Gross authored
Move all the gossip keyring and key generation commands under `operator gossip keyring` subcommands to align with the new `operator secure-variables keyring` subcommands. Deprecate the `operator keyring` and `operator keygen` commands.
-
Phil Renaud authored
* Add modified times and namespaces to layout * Undo typing change * Post-hoc accounting for new variable path routing
-
Tim Gross authored
The blocking query for `Keyring.List` appended the keys for each pass through the blocking query to the response. This results in mulitple copies of keys in the response. Overwrite the `reply.Keys` field on each pass through the blocking query to ensure we only get the expected page of responses.
-
Tim Gross authored
Adds a new policy block inside namespaces to control access to secure variables on the basis of path, with support for globbing. Splits out VerifyClaim from ResolveClaim. The ServiceRegistration RPC only needs to be able to verify that a claim is valid for some allocation in the store; it doesn't care about implicit policies or capabilities. Split this out to its own method on the server so that the SecureVariables RPC can reuse it as a separate step from resolving policies (see next commit). Support implicit policies based on workload identity
-
Tim Gross authored
The `Encrypt` method generates an appropriately-sized nonce and uses that buffer as the prefix for the ciphertext. This keeps the ciphertext and nonce together for decryption, and reuses the buffer as much as possible without presenting the temptation to reuse the cleartext buffer owned by the caller. We include the key ID as the "additional data" field that's used as an extra input to the authentication signature, to provide additional protection that a ciphertext originated with that key. Refactors the locking for the keyring so that the public methods are generally (with one commented exception) responsible for taking the lock and then inner methods are assumed locked.
-
Charlie Voiselle authored
* Add Path only index for SecureVariables * Add GetSecureVariablesByPrefix; refactor tests * Add search for SecureVariables * Add prefix search for secure variables
-
Jai authored
* chore: update tests to handle invidual toggle responsibility * chore: prettify secure-variable-form template * ui: extract input group markup into seperate component
-
Jai authored
* ui: update component api to accept callback fns to be fired on cancel/prompt * refact: cancel callback should fire with outside click handler not on idle * refact: rename action to be more specific
-
Phil Renaud authored
* toast style notification init * Notificatino styles and messaging for variable save * pre-PR cleanup * Typo fix and 5sec timeout * Prevent text from overlapping the close button
-
Phil Renaud authored
* Bones of a just-in-time compaction pathTree * wooo got compaction going in sub-ms times * PR cleanup * Path compaction tests * lint fix to equal instead of .ok() * Name prop specifically being equality checked
-
Charlie Voiselle authored
This PR splits SecureVariable into SecureVariableDecrypted and SecureVariableEncrypted in order to use the type system to help verify that cleartext secret material is not committed to file. * Make Encrypt function return KeyID * Split SecureVariable Co-authored-by:
Tim Gross <tgross@hashicorp.com>
-
Tim Gross authored
Split the flag options for the `secure-variables keyring` into their own subcommands. The gossip keyring CLI will be similarly refactored and the old version will be deprecated.
-
Phil Renaud authored
* Validation tests for secure variables form: duplicate path error * Validation for dot in key name * Defensive pattern on copy keyValues
-
Phil Renaud authored
* variable index header and deletion hook * Some visual improvements to edit header and back button * Mirage fixtures for variables * Deletion flow test * Account for disabled state of add-more button * Transition destination changes after design chat * Simplified parent folder path by adding to variable model * Lint cleanup * test update to reflect path redirect on delete * No longer have to re-traverse to a deleted var folder after deletion, tests updated
-
Tim Gross authored
In order to support implicit ACL policies for tasks to get their own secrets, each task would need to have its own ACL token. This would add extra raft overhead as well as new garbage collection jobs for cleaning up task-specific ACL tokens. Instead, Nomad will create a workload Identity Claim for each task. An Identity Claim is a JSON Web Token (JWT) signed by the server’s private key and attached to an Allocation at the time a plan is applied. The encoded JWT can be submitted as the X-Nomad-Token header to replace ACL token secret IDs for the RPCs that support identity claims. Whenever a key is is added to a server’s keyring, it will use the key as the seed for a Ed25519 public-private private keypair. That keypair will be used for signing the JWT and for verifying the JWT. This implementation is a ruthlessly minimal approach to support the secure variables feature. When a JWT is verified, the allocation ID will be checked against the Nomad state store, and non-existent...
-
Phil Renaud authored
* Notify a user if they try to make a variable with an existing path * Stylize error fade * Bugfix: if you click the dupe link to a variable you havent previously loaded, you lack its keyvalues * rename and typefix for duplicate path warning
-
Phil Renaud authored
* Disable path input when model is not new * isDisabled tests for secure variables path
-
Tim Gross authored
Co-authored-by:
Charlie Voiselle <464492+angrycub@users.noreply.github.com>
-
Charlie Voiselle authored
-
Tim Gross authored
Replication for the secure variables keyring. Because only key metadata is stored in raft, we need to distribute key material out-of-band from raft replication. A goroutine runs on each server and watches for changes to the `RootKeyMeta`. When a new key is received, attempt to fetch the key from the leader. If the leader doesn't have the key (which may happen if a key is rotated right before a leader transition), try to get the key from any peer.
-
Phil Renaud authored
* Recursive trie-building with variable paths * tree structure applied to new path routes and a new util class * Breadcrumbs for SV paths and prompt when nothing exists at a path * Lint and test cleanup * Pre-review cleanup * lintfix * Abstracted pathtree each-ins into a new component class * Path tree component styles * Types added and PR feedback addressed * Path tree to variable paths * Slightly simpler path QP mods * More pr feedback handling * Trim moved into a function on variable model * Traversal and compaction tests for PathTree * Trim Path tests * Variable-paths component tests * Lint fixup for tests
-
Tim Gross authored
Inactive and unused keys older than a threshold will be periodically garbage collected.
-
Tim Gross authored
After internal design review, we decided to remove exposing algorithm choice to the end-user for the initial release. We'll solve nonce rotation by forcing rotations automatically on key GC (in a core job, not included in this changeset). Default to AES-256 GCM for the following criteria: * faster implementation when hardware acceleration is available * FIPS compliant * implementation in pure go * post-quantum resistance Also fixed a bug in the decoding from keystore and switched to a harder-to-misuse encoding method.
-
Tim Gross authored
The core jobs to garbage collect unused keys and perform full key rotations will need to be able to query secure variables by key ID for efficiency. Add an index to the state store and associated query function and test.
-
Tim Gross authored
When a server becomes leader, it will check if there are any keys in the state store, and create one if there is not. The key metadata will be replicated via raft to all followers, who will then get the key material via key replication (not implemented in this changeset).
-
Phil Renaud authored
* variables.new initialized * Hacky but savey * Variable wildcard route and multiple creatable at a time * multiple KVs per variable * PR Prep cleanup and lintfix * Delog * Data mocking in mirage for variables * Linting fixes * Re-implement absent params * Adapter and model tests * Moves the path-as-id logic to a serializer instead of adapter * Classic to serializer and lint cleanup * Pluralized save button (#13140) * Autofocus modifier and better Add More button UX (#13145) * Secure Variables: show/hide functionality when adding new values (#13137) * Flight Icons added and show hide functionality * PR cleanup * Linting cleanup * Position of icon moved to the right of input * PR feedback addressed * Delete button and stylistic changes to show hide * Hmm, eslint doesnt like jsdoc-usage as only reason for import * More closely match the button styles and delete test * Simplified new.js model * Secure Variables: /variables/*path/edit route and functionality (#13170) * Variable edit page init * Significant change to where we house model methods * Lintfix * Edit a variable tests * Remove redundant tests * Asserts expected * Mirage factory updated to reflect model state
-
Charlie Voiselle authored
* Secure Variables: State Store * Secure Variables: FSM * Secure Variables: RPC * Secure Variables: HTTP API Co-authored-by:
Tim Gross <tgross@hashicorp.com>
-
Tim Gross authored
This changeset implements the keystore serialization/deserialization: * Adds a JSON serialization extension for the `RootKey` struct, along with a metadata stub. When we serialize RootKey to the on-disk keystore, we want to base64 encode the key material but also exclude any frequently-changing fields which are stored in raft. * Implements methods for loading/saving keys to the keystore. * Implements methods for restoring the whole keystore from disk. * Wires it all up with the `Keyring` RPC handlers and fixes up any fallout on tests.
-
Tim Gross authored
-
Tim Gross authored
Implement the upsert, list, delete, and rotate RPC handlers for the secure variables keyring. Operations on the keyring itself are still stubbed out.
-
Tim Gross authored
Implement the basic upsert, list, and delete operations for `RootKeyMeta` needed by the Keyring RPCs. This changeset also implements two convenience methods `RootKeyMetaByID` and `GetActiveRootKeyMeta` which are useful for testing but also will be needed to implement the rest of the RPCs.
-
Phil Renaud authored
* Route init * Bones of a mirage-mocked secure variables policy * Functinoing policy for list vars * Delog and transition on route * Basic guard test * Page guard tests for secure variables * Cleanup and unit tests for variables ability * Linter cleanup * Set expectations for test assertions * PR feedback addressed * Read label changed to View per suggestion
-
Charlie Voiselle authored
* Add SecureVariable mock * Add SecureVariableStub * Add SecureVariable Copy and Stub funcs
-