This project is mirrored from https://gitee.com/mirrors/nomad.git.
Pull mirroring failed .
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
Repository mirroring has been paused due to too many failed attempts. It can be resumed by a project maintainer.
- 01 Sep, 2022 1 commit
-
-
James Rasell authored
Log lines which include an error should use the full term "error" as the context key. This provides consistency across the codebase and avoids a Go style which operators might not be aware of.
-
- 11 Oct, 2021 1 commit
-
-
Ben Buzbee authored
We see this error all the time ``` no handler registered for event event.Message=, event.Annotations=, event.Timestamp=0001-01-01T00:00:00Z, event.TaskName=, event.AllocID=, event.TaskID=, ``` So we're handling an even with all default fields. I noted that this can happen if only err is set as in ``` func (d *driverPluginClient) handleTaskEvents(reqCtx context.Context, ch chan *TaskEvent, stream proto.Driver_TaskEventsClient) { defer close(ch) for { ev, err := stream.Recv() if err != nil { if err != io.EOF { ch <- &TaskEvent{ Err: grpcutils.HandleReqCtxGrpcErr(err, reqCtx, d.doneCtx), } } ``` In this case Err fails to be serialized by the logger, see this test ``` ev := &drivers.TaskEvent{ Err: fmt.Errorf("errz"), } i.logger.Warn("ben test", "event", ev) i.logger.Warn("ben test2", "event err str", ev.Err.Error()) i.logger.Warn("ben test3", "event err", ev.Err) ev.Err = nil i.logger.Warn("ben test4", "nil error", ev....
-
- 26 May, 2020 1 commit
-
-
Mahmood Ali authored
This fixes few cases where driver eventor goroutines are leaked during normal operations, but especially so in tests. This change makes few modifications: First, it switches drivers to use `Context`s to manage shutdown events. Previously, it relied on callers invoking `.Shutdown()` function that is specific to internal drivers only and require casting. Using `Contexts` provide a consistent idiomatic way to manage lifecycle for both internal and external drivers. Also, I discovered few places where we don't clean up a temporary driver instance in the plugin catalog code, where we dispense a driver to inspect and validate the schema config without properly cleaning it up.
-
- 15 Feb, 2020 1 commit
-
-
Nick Ethier authored
-
- 21 Oct, 2019 1 commit
-
-
Mahmood Ali authored
At shutdown, driver manager context expires and the fingerprinting channel closes. Thus it is undeterministic which clause of The select statement gets executed, and we may keep retrying until the `i.ctx.Done()` block is executed. Here, we check always check ctx expiration before retrying again.
-
- 21 Feb, 2019 1 commit
-
-
Michael Schurter authored
The initial fingerprint message is actually fairly useful, so I bumped it to Debug and fixed the output formatting.
-
- 23 Jan, 2019 1 commit
-
-
Michael Schurter authored
-
- 22 Jan, 2019 2 commits
-
-
Michael Schurter authored
I wanted a different color bikeshed, so I get to paint it
-
Alex Dadgar authored
-
- 08 Jan, 2019 1 commit
-
-
Danielle Tomlinson authored
This allows us to correctly terminate internal state during runs of the nomad test suite, e.g closing eventer contexts correctly.
-
- 07 Jan, 2019 2 commits
-
-
Alex Dadgar authored
-
Alex Dadgar authored
-
- 19 Dec, 2018 4 commits
-
-
Nick Ethier authored
-
Nick Ethier authored
-
Nick Ethier authored
drivermanager: fix pr comments/feedback
-
Nick Ethier authored
The driver manager is modeled after the device manager and is started by the client. It's responsible for handling driver lifecycle and reattachment state, as well as processing the incomming fingerprint and task events from each driver. The mananger exposes a method for registering event handlers for task events that is used by the task runner to update the server when a task has been updated with an event. Since driver fingerprinting has been implemented by the driver manager, it is no longer needed in the fingerprint mananger and has been removed.
-