Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
小 白蛋
Nomad
Commits
5304c612
Unverified
Commit
5304c612
authored
6 years ago
by
Nick Ethier
Browse files
Options
Download
Email Patches
Plain Diff
drivers/docker: handle shutdown of upgraded tasks correctly
parent
e2bc4f3f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
drivers/docker/driver_pre09.go
+1
-1
drivers/docker/driver_pre09.go
drivers/shared/executor/legacy_executor_wrapper.go
+16
-2
drivers/shared/executor/legacy_executor_wrapper.go
with
17 additions
and
3 deletions
+17
-3
drivers/docker/driver_pre09.go
+
1
-
1
View file @
5304c612
...
...
@@ -69,7 +69,7 @@ type executorDockerLoggerShim struct {
func
(
e
*
executorDockerLoggerShim
)
Start
(
*
docklog
.
StartOpts
)
error
{
return
nil
}
func
(
e
*
executorDockerLoggerShim
)
Stop
()
error
{
if
err
:=
e
.
exec
.
Shutdown
(
""
,
0
);
err
!=
nil
{
if
err
:=
e
.
exec
.
Shutdown
(
"
docker
"
,
0
);
err
!=
nil
{
return
err
}
...
...
This diff is collapsed.
Click to expand it.
drivers/shared/executor/legacy_executor_wrapper.go
+
16
-
2
View file @
5304c612
...
...
@@ -15,6 +15,12 @@ import (
"golang.org/x/net/context"
)
const
(
// pre09DockerSignal is used in executor.Shutdown to know if it should
// call the ShutDown RPC on the pre09 executor
pre09DockerSignal
=
"docker"
)
// Registering these types since we have to serialize and de-serialize the Task
// structs over the wire between drivers and the executor.
func
init
()
{
...
...
@@ -49,8 +55,16 @@ func (l *legacyExecutorWrapper) Wait(ctx context.Context) (*ProcessState, error)
}
func
(
l
*
legacyExecutorWrapper
)
Shutdown
(
signal
string
,
gracePeriod
time
.
Duration
)
error
{
if
err
:=
l
.
client
.
ShutDown
();
err
!=
nil
{
return
err
// The legacy docker driver only used the executor to start a syslog server
// for logging. Thus calling ShutDown for docker will always return an error
// because it never started a process through the executor. If signal is set
// to 'docker' then we'll skip the ShutDown RPC and just call Exit.
//
// This is painful to look at but will only be around a few releases
if
signal
!=
pre09DockerSignal
{
if
err
:=
l
.
client
.
ShutDown
();
err
!=
nil
{
return
err
}
}
if
err
:=
l
.
client
.
Exit
();
err
!=
nil
{
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment