• Eng Zer Jun's avatar
    test: use `T.TempDir` to create temporary test directory (#12853) · fca4ee8e
    Eng Zer Jun authored
    * test: use `T.TempDir` to create temporary test directory
    
    This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
    directory created by `t.TempDir` is automatically removed when the test
    and all its subtests complete.
    
    Prior to this commit, temporary directory created using `ioutil.TempDir`
    needs to be removed manually by calling `os.RemoveAll`, which is omitted
    in some tests. The error handling boilerplate e.g.
    	defer func() {
    		if err := os.RemoveAll(dir); err != nil {
    			t.Fatal(err)
    		}
    	}
    is also tedious, but `t.TempDir` handles this for us nicely.
    
    Reference: https://pkg.go.dev/testing#T.TempDir
    
    Signed-off-by: default avatarEng Zer Jun <engzerjun@gmail.com>
    
    * test: fix TestLogmon_Start_restart on Windows
    Signed-off-by: default avatarEng Zer Jun <engzerjun@gmail.com>
    
    * test: fix failing TestConsul_Integration
    
    t.TempDir fails to perform the cleanup properly because the folder is
    still in use
    
    testing.go:967: TempDir Re...
    fca4ee8e