• Michael Schurter's avatar
    Fix race in framer and improperly returned err · ac3fffc1
    Michael Schurter authored
    Fixes #3342
    
    Two bugs were fixed:
    
    * Closing the StreamFramer's exitCh before setting the error means other
      goroutines blocked on exitCh closing could see the error as nil. This
      was *not* observered.
    * parseFramerError on Windows would fall through and return an
      improperly captured nil err variable. There's no need for
      parseFramerError to be a closure which fixes the confusion.
    ac3fffc1