• Mahmood Ali's avatar
    client: avoid acting on stale data after launch (#10907) · 18621799
    Mahmood Ali authored
    When the client launches, use a consistent read to fetch its own allocs,
    but allow stale read afterwards as long as reads don't revert into older
    state.
    
    This change addresses an edge case affecting restarting client. When a
    client restarts, it may fetch a stale data concerning its allocs: allocs
    that have completed prior to the client shutdown may still have "run/running"
    desired/client status, and have the client attempt to re-run again.
    
    An alternative approach is to track the indices such that the client
    set MinQueryIndex on the maximum index the client ever saw, or compare
    received allocs against locally restored client state. Garbage
    collection complicates this approach (local knowledge is not complete),
    and the approach still risks starting "dead" allocations (e.g. the
    allocation may have been placed when client just restarted and have
    already been reschuled by the time the client started. This approach
    here is effective against all kinds of stalness problems with small
    overhead.
    18621799