Before we could accidentally take action on a failed read before checking 'shouldRetry'.
This meant, in some tests, we could end up trying to create an array of negative size.
In production this is not a problem (up until at least 4.2) because we don't have any
indexes that offload store and also store data in the values.
(Only BTREE indexes use offload store)

The purpose of this change is to guarantee configured IOPS limits.

Before this change, the page cache could flush more aggressively
than the IOPS limit depending on layout of dirty pages.
The reason was that it processed 4k page segments before invoking
the IO limiter which would block only for up to 100ms.
This could lead to pages being flushed at rate up to 40k/s,
depending on the distribution of dirty pages
among the 4k page segments.

We don’t use java-modules, so all modules are undefined. Therefor the search is broken. To fix this, we can explicitly state the use of module directories to false, so that the JavaScript based search won’t lead to classes being in an `UNDEFINED` directory.

Related fix in the Java Driver repo https://github.com/neo4j/neo4j-java-driver/commit/d7c1c1c87d9bba5ceaa9c7a6bcfe9206f225bb41.

In planning whenever we encountered an eventually consistent
index we throw an error when trying to map the behaviour to a scala
equivalent.

changelog: Fix error where we could get an error Missing kernel to cypher mapping for index behaviour: EVENTUALLY_CONSISTENT in Cypher.

This is because the original is based on some assumptions about transaction logs, which are not necessarily accurate.

This fixes a bug where we were actually sending the full-size in the dump-size field.

There are some dependencies between the user log settings that aren't obvious - now documented.

Fix a bug in PIPELINE runtime with fusing when evaluating AND/OR expressions.

Changes the diagnostics messages' indentation to be aligned with the other
log messages instead of left aligned.

The bytes values were written as decimal numbers but the SettingValueParser didn't
support decimal points. This meant that the default values in the documentation
weren't actually valid values.
Now the values that will end up in the docs are printed with the highest unit
they can use without needing a decimal point instead.

Also adds a test that verifies that the string representation of our default values
for settings are parsable.

For queries using pruning varExpand with a predicate we were only
evaluating the predicate on the relationship and the node we are
expanding to - not the node we were coming from. This leads to the
wrong results for some queries.

changelog: Fix bug where predicate in WHERE clause was ignored for queries combining
variable lenght pattern and DISTINCT.

This fixes an interaction problem with isolateAggregation.

Add test for case where pattern comprehension is under an all condition from https://github.com/neo4j/neo4j/issues/12583

Each relationship chain holds the total length of the chain (degree) in
the prev pointer of the first relationship. When deleting a relationship
that wasn't the first in the chain, but where the first relationship in
that chain happened to be a loop relationship the degree would be
decremented twice for one of the degree slots.

In turn this would cause degree for that chain to be skewed from
that point onwards and would result in inconsistent counts with what
the counts store had if e.g. labels were changed after this point.

There was an issue where the volumetric checkpoint policy (which uses
log pruning to check if check point can be made) and the actual log pruning
wouldn't use the same upper log version bound and so if no further write
transaction was committed the db would be stuck in a state of infinite
checkpointing (or rather checkpoint on every check) because it would
look like it could do checkpoint, but log pruning would not prune any log.

Leftovers from "Removal of Batch Endpoint" at the end of February 2019.

See dc58dff71e0cd380bfbfe636b5cc2edac0f509e6 and 6a1759fbeb2219bffdf009dcbe108d4a635734c7.

- Update test that should throw error to validate error message
- databaseId -> getDatabaseId
- Update error message