Vitaly Provodin

GitOrigin-RevId: 75c8562f0da539e1437559bfa3a2f3e569471106

(cherry picked from commit 4dfef3eaf09dcfb3f2f836916b648fd6013bd03a)

GitOrigin-RevId: 507327b1c9580a5b275b99211506c00cc55895e0

(cherry picked from commit 2fd35815b943ede3ce8f65afd795f9d1b87e3ca1)

GitOrigin-RevId: afa4fe0ce3f3803ac1b2b2c66999027b309894c0

In order to implement this action properly with workspace model, we now recreate serializers in JpsProjectModelSynchronizer and change entitySource for project-level libraries from *.ipr file to file under .idea/libraries. (We'll need to do the same for artifacts when we migrate them to workspace model.)

(cherry picked from commit 00a3ebbb8df8a2b3799241e0589836a8f3eef68e, IDEA-CR-71415)

GitOrigin-RevId: ef7c612c8862223eba2b6997be26442d366849f3

[workspace model] properly handle cases when a module containing module libraries is removed and added back (IDEA-264111)

Such cases may happen for example if a directory containing pom.xml is moved to another directory. We shouldn't remove entities for its libraries in such cases, otherwise the storage becomes inconsistent and attempt to save module configuration will fail.

(cherry picked from commit b42cc40412e3888d52d3d884b7702f2e8ac45f7e)

IDEA-CR-71450

GitOrigin-RevId: 66d11ff23a7c98c19a728a7e7421b790f92f9f8b

[Java FX] get rid of reference to class from 'properties' plugin from the main part of the plugin (IDEA-269139)

JavaFX plugin has optional dependency on Properties plugin, so it may use its classes only from the corresponding part.

(cherry picked from commit 4a67fc51e4b299697c82a73985b40f7366e7f33e)

IJ-CR-9210

GitOrigin-RevId: dab1ed7a63d00d807551ac519e1f62babb88f027

(cherry picked from commit 1c2bf49ba35ffee23cf1c51ad605e5984c0c0d21)

GitOrigin-RevId: 148d8c576fc3925d625a7784ca4b0d016d115c03

(cherry picked from commit 6b686fb2057458643dd4e5f483a2ba0adb5adf82)

GitOrigin-RevId: b258a098437c95bc29d4bb874bd34d7e0bdd56c3

IDEA-253961

(cherry picked from commit fbc713862397254d9d26def48763d70b2c8f2ee3)

GitOrigin-RevId: 8b4c23cc246f616d05b085e85404f2c6d9d933c5

(cherry picked from commit 49d77524ed510bd734f3aa4a0c6c002ff5d8a0b8)

GitOrigin-RevId: 5e727852cf5e6268be06b83b6f75fd1dd1572621

Mikhail Grishchenko

GitOrigin-RevId: 88ab402ba8374712b2cbd41c6d47974edcb9b61b

(cherry picked from commit 3383761bb93b20c9901d02e4a903ff8c31a32ffb)

IJ-CR-9211

GitOrigin-RevId: 4bed63eacef33fe55d206dd0de6a39776770e377

But still track it for changes and count it in metrics.

(cherry picked from commit 281bf64ec3fd293e55c4aa976d41e446f69c7ce4)

IJ-CR-9181

GitOrigin-RevId: 72170c414c0c39283b2ccdcc6748119beb4f5443

This reverts commit 2f8521d4bd972906488fb8ab35f20ac60e33f16a.

GitOrigin-RevId: c702ab2af15523061bff00886f6225a4e0735d04

(cherry picked from commit 14d8105e57d60284c8185b16477b57ba950fd227)

IJ-CR-8891

GitOrigin-RevId: edbc234aca610b9a1a7a60f5b81e865a7a26800c

GitOrigin-RevId: 2a404d299f0efda66aaa6ba6b8c47afbf0e9de59

IDEA-261718 Application run configuration: inner class is prefixed with dollar and is reported invalid

(cherry picked from commit d7076e6fa90fd24c3943290f2e8b8880407bec68)

GitOrigin-RevId: 320863caa7a5751e14e31bc16d1b1859000b6839

IDEA-261718 Application run configuration: inner class is prefixed with dollar and is reported invalid

(cherry picked from commit d7076e6fa90fd24c3943290f2e8b8880407bec68)

GitOrigin-RevId: bb36f5ff72457222d38c947f3d2541ddb661afab

GitOrigin-RevId: f33911d9facf238ff4407923d4570d64480ab343

(cherry picked from commit 175e716913c79f2a8c318797483115647782411f)

IJ-CR-9148

GitOrigin-RevId: 5c8f96d50fc26cd22e2cc05addc2fbbe72f55a2f

(cherry picked from commit 7b6f0301b6ab13b6aaac9febfe7408cdb5c5be21, IDEA-CR-71415)

GitOrigin-RevId: b489ee5faea3551c897d67728d44a0ff5640c5aa

In order to implement this action properly with workspace model, we now recreate serializers in JpsProjectModelSynchronizer and change entitySource for project-level libraries from *.ipr file to file under .idea/libraries. (We'll need to do the same for artifacts when we migrate them to workspace model.)

(cherry picked from commit 00a3ebbb8df8a2b3799241e0589836a8f3eef68e, IDEA-CR-71415)

GitOrigin-RevId: 81394bbe168e7951657bed19008e0ed0df4aeaf5

(cherry picked from commit 7af15b1027f7c815feec9b8b66bca5c0bf325633)

IJ-CR-9121

GitOrigin-RevId: 8ebf4a27b114896cb734cc4dc4c58fce8e4926d9

(cherry picked from commit 67bc828b476ada4091b397e644c92fae456b27a3)

GitOrigin-RevId: c5895552ebf56515c778ec723dc63ce981392972

Necessary for synthetic record accessors
Fixes IDEA-268161 NonNullApi does not work with Java record "getters"

(cherry picked from commit 365df82890ccb7d42144bac8cd8c87d727403f57)

IJ-CR-8979

GitOrigin-RevId: f1d92b66b9d1612e9debaa1ae7e91d399497d448

(cherry picked from commit 4b4d0af7b1fa069ae6d50b83738fa918b348fcee)

IJ-CR-8979

GitOrigin-RevId: 28617c388b97d770c91718a58047bb0250724254

IDEA-264593 [groovy] optimize definition maps for caching by limiting number of different referenced instances

(cherry picked from commit 58728803b4ec6b09e51ca81cd7851d1144980774)

IJ-CR-9022

GitOrigin-RevId: 3f26488ddc36d3ea116a11283996fb0d6d393396

(cherry picked from commit d0bbf98d9acaf70ab3a95ad2e2f2124d2e3ecb26)

IJ-CR-9020

GitOrigin-RevId: 16fd6b67410ac5a4018d667a3f0bcbaa9a9dd456

In `ReachingDefinitionsCollector` the `DefinitionMap` was used as a holder for `Int2ObjectMap<IntSet>`.

(cherry picked from commit 836eda91aa72e46530a9c121b2f8cfdf5135bdc8)

IJ-CR-9019

GitOrigin-RevId: 98cc22117ed74b27be682d1254a8ddfd6c590b99

(cherry picked from commit 0099a90137a07d6fdb34d631cfa358f929f956fd)

IJ-CR-9018

GitOrigin-RevId: 94a1307656b30e8b3ba97afc18a124ed631f5601

(cherry picked from commit 11f481a99ab957fbf70657c1891316ef28019123)

IJ-CR-9049

GitOrigin-RevId: 7a038902e9bf69aa09e987c127c4a7112219794c

Otherwise it'll call updateProjectModel under write action, and this will slow down importing if many project are unlinked.

(cherry picked from commit 74d2c9201ab1ac637ddb3add0ebaa20a3832fec3)

IDEA-CR-71370

GitOrigin-RevId: 7d7132d9dd3dbe01d4c8ef2b10ccf9e9e53b24c4

[workspace model] remove specified dependency only if there are several equal dependencies (IDEA-267246, IDEA-256694)

If there are several instances of OrderEntry with equal properties, implementation of ModifiableRootModel.removeOrderEntry in the old model removes the specified instance only, where as implementation in the new model removed all of them. So MavenRootModelAdapterLegacyImpl::initOrderEntries removed all copies after calling removeOrderEntry for the first instance, and failed with "does not belong to modifiableRootModel" error when trying to remove remaining copies. Also in UI it looks strange if removing one item in the dependencies list removes other copies automatically. So now ModifiableRootModel.removeOrderEntry removes the specified entry only in the new implementation as well.

(cherry picked from commit 54cdce78b27134988e9b68c393f4985d977dfa1d)

IDEA-CR-71377

GitOrigin-RevId: 9542e5fa15df37c9beee6cc536d70205a1eab103

[workspace model] restore mapping for module-level libraries when ModifiableRootModel is disposed (IDEA-266964)

ModifiableModelCommitterServiceBridge::multiCommit disposes root model which contain no changes, so we need to restore mapping to original instance of LibraryBridge, otherwise after commit we'll end up with references to disposed LibraryBridge instances.
(cherry picked from commit 6d1cfda78761b5dcb02761954dceb6a96a88011e)

IDEA-CR-71369

GitOrigin-RevId: df1e6d2d42b77da5afd34aaeade19c77befca46b

The default instantiator creates instance of LinkedHashSet via reflection and its 'map' field will be set to 'null', so any attempt to access content of the set will fail with NPE.

(cherry picked from commit 64aa6bae48913820d0b36cbf3b58ccde992362d4)

IDEA-CR-71358

GitOrigin-RevId: e81e8cf877f06cad61478796852307aff1d503dd

(cherry picked from commit b0c77b19a2bc8833e5545282e1541d3867713dad)

IDEA-CR-71410

GitOrigin-RevId: 0287480e3fca5da56beb20546669bd6248113c81

Vitaly Provodin

GitOrigin-RevId: 723f88095cf989619580e43bb23217108290a451

(cherry picked from commit 3ab96fa31325f20e7ab8827c7cba120635ffae4a)

IJ-CR-8763

GitOrigin-RevId: 8d660c9f7e255008208dd0cb907b51335eda2913

(cherry picked from commit e7636b1b0717eacea2715a3666ec890e9a967867)

GitOrigin-RevId: f9c679d9edc0cd26f535f37db5febb2faa7250fd

(cherry picked from commit 972ba80ac919a09433f08f7b2b5f6c5bc65a1de3)

GitOrigin-RevId: 977c95acc15df30edcff76c099aa61e85f510763