Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
小 白蛋
Intellij Community
Commits
c9694995
Commit
c9694995
authored
6 years ago
by
peter
Browse files
Options
Download
Email Patches
Plain Diff
IDEA-199875 Rank `println` higher than `print`
parent
2d9a2e83
Branches unavailable
Tags unavailable
No related merge requests found
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
java/java-impl/src/com/intellij/psi/util/proximity/KnownElementWeigher.java
+6
-2
.../com/intellij/psi/util/proximity/KnownElementWeigher.java
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/lambda/completion/normal/NoSemicolonAfterVoidMethodInLambda_after.java
+1
-1
...tion/normal/NoSemicolonAfterVoidMethodInLambda_after.java
java/java-tests/testSrc/com/intellij/java/codeInsight/completion/JavaAutoPopupTest.groovy
+1
-16
...llij/java/codeInsight/completion/JavaAutoPopupTest.groovy
java/java-tests/testSrc/com/intellij/java/codeInsight/completion/NormalCompletionOrderingTest.groovy
+8
-0
...odeInsight/completion/NormalCompletionOrderingTest.groovy
with
16 additions
and
19 deletions
+16
-19
java/java-impl/src/com/intellij/psi/util/proximity/KnownElementWeigher.java
+
6
-
2
View file @
c9694995
...
@@ -84,7 +84,11 @@ public class KnownElementWeigher extends ProximityWeigher {
...
@@ -84,7 +84,11 @@ public class KnownElementWeigher extends ProximityWeigher {
if
(
JAVA_LANG_OBJECT
.
equals
(
containingClass
.
getQualifiedName
()))
{
if
(
JAVA_LANG_OBJECT
.
equals
(
containingClass
.
getQualifiedName
()))
{
return
0
;
return
0
;
}
}
return
getJdkClassProximity
(
method
.
getContainingClass
());
Integer
classProximity
=
getJdkClassProximity
(
containingClass
);
if
(
classProximity
!=
null
&&
"println"
.
equals
(
methodName
)
&&
method
.
getParameterList
().
getParametersCount
()
>
0
)
{
return
1
+
classProximity
;
}
return
classProximity
;
}
}
}
}
if
(
element
instanceof
PsiField
)
{
if
(
element
instanceof
PsiField
)
{
...
@@ -116,7 +120,7 @@ public class KnownElementWeigher extends ProximityWeigher {
...
@@ -116,7 +120,7 @@ public class KnownElementWeigher extends ProximityWeigher {
return
"getClass"
.
equals
(
method
.
getName
())
&&
method
.
getParameterList
().
getParametersCount
()
<=
0
;
return
"getClass"
.
equals
(
method
.
getName
())
&&
method
.
getParameterList
().
getParametersCount
()
<=
0
;
}
}
private
static
Comparable
getJdkClassProximity
(
@Nullable
PsiClass
element
)
{
private
static
Integer
getJdkClassProximity
(
@Nullable
PsiClass
element
)
{
String
qname
=
element
==
null
?
null
:
element
.
getQualifiedName
();
String
qname
=
element
==
null
?
null
:
element
.
getQualifiedName
();
if
(
qname
==
null
)
return
null
;
if
(
qname
==
null
)
return
null
;
...
...
This diff is collapsed.
Click to expand it.
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/lambda/completion/normal/NoSemicolonAfterVoidMethodInLambda_after.java
+
1
-
1
View file @
c9694995
public
class
Util
{
public
class
Util
{
{
{
foo
(()
->
System
.
out
.
println
(
)
<
caret
>).
bar
();
foo
(()
->
System
.
out
.
println
(<
caret
>)
)
.
bar
();
}
}
}
}
\ No newline at end of file
This diff is collapsed.
Click to expand it.
java/java-tests/testSrc/com/intellij/java/codeInsight/completion/JavaAutoPopupTest.groovy
+
1
-
16
View file @
c9694995
...
@@ -23,7 +23,6 @@ import com.intellij.openapi.actionSystem.IdeActions
...
@@ -23,7 +23,6 @@ import com.intellij.openapi.actionSystem.IdeActions
import
com.intellij.openapi.application.ApplicationManager
import
com.intellij.openapi.application.ApplicationManager
import
com.intellij.openapi.command.CommandProcessor
import
com.intellij.openapi.command.CommandProcessor
import
com.intellij.openapi.command.WriteCommandAction
import
com.intellij.openapi.command.WriteCommandAction
import
com.intellij.openapi.fileEditor.impl.CurrentEditorProvider
import
com.intellij.openapi.command.impl.UndoManagerImpl
import
com.intellij.openapi.command.impl.UndoManagerImpl
import
com.intellij.openapi.command.undo.UndoManager
import
com.intellij.openapi.command.undo.UndoManager
import
com.intellij.openapi.editor.Editor
import
com.intellij.openapi.editor.Editor
...
@@ -36,6 +35,7 @@ import com.intellij.openapi.extensions.Extensions
...
@@ -36,6 +35,7 @@ import com.intellij.openapi.extensions.Extensions
import
com.intellij.openapi.extensions.LoadingOrder
import
com.intellij.openapi.extensions.LoadingOrder
import
com.intellij.openapi.fileEditor.FileEditor
import
com.intellij.openapi.fileEditor.FileEditor
import
com.intellij.openapi.fileEditor.FileEditorManager
import
com.intellij.openapi.fileEditor.FileEditorManager
import
com.intellij.openapi.fileEditor.impl.CurrentEditorProvider
import
com.intellij.openapi.progress.ProgressManager
import
com.intellij.openapi.progress.ProgressManager
import
com.intellij.openapi.util.Computable
import
com.intellij.openapi.util.Computable
import
com.intellij.openapi.util.Disposer
import
com.intellij.openapi.util.Disposer
...
@@ -43,15 +43,12 @@ import com.intellij.psi.NavigatablePsiElement
...
@@ -43,15 +43,12 @@ import com.intellij.psi.NavigatablePsiElement
import
com.intellij.psi.PsiClass
import
com.intellij.psi.PsiClass
import
com.intellij.psi.PsiJavaFile
import
com.intellij.psi.PsiJavaFile
import
com.intellij.psi.PsiMethod
import
com.intellij.psi.PsiMethod
import
com.intellij.psi.statistics.StatisticsManager
import
com.intellij.psi.statistics.impl.StatisticsManagerImpl
import
com.intellij.testFramework.fixtures.CodeInsightTestUtil
import
com.intellij.testFramework.fixtures.CodeInsightTestUtil
import
com.intellij.util.ThrowableRunnable
import
com.intellij.util.ThrowableRunnable
import
com.intellij.util.containers.ContainerUtil
import
com.intellij.util.containers.ContainerUtil
import
org.jetbrains.annotations.NotNull
import
org.jetbrains.annotations.NotNull
import
java.awt.event.KeyEvent
import
java.awt.event.KeyEvent
/**
/**
* @author peter
* @author peter
*/
*/
...
@@ -1521,18 +1518,6 @@ class Foo {
...
@@ -1521,18 +1518,6 @@ class Foo {
assert
!
lookup
assert
!
lookup
}
}
void
testReplaceTypedPrefixPart
()
{
((
StatisticsManagerImpl
)
StatisticsManager
.
getInstance
()).
enableStatistics
(
myFixture
.
getTestRootDisposable
())
myFixture
.
configureByText
'a.java'
,
'class Foo{ { <caret> }}'
for
(
i
in
0
..
StatisticsManager
.
OBLIVION_THRESHOLD
)
{
type
'System.out.printl\n\n'
}
type
'System.out.pr'
assert
lookup
.
currentItem
.
lookupString
==
'println'
type
'\n2'
assert
myFixture
.
editor
.
document
.
text
.
contains
(
'.println();2'
)
}
void
testQuickBackspaceEnter
()
{
void
testQuickBackspaceEnter
()
{
myFixture
.
configureByText
'a.java'
,
'<caret>'
myFixture
.
configureByText
'a.java'
,
'<caret>'
type
'cl'
type
'cl'
...
...
This diff is collapsed.
Click to expand it.
java/java-tests/testSrc/com/intellij/java/codeInsight/completion/NormalCompletionOrderingTest.groovy
+
8
-
0
View file @
c9694995
...
@@ -867,4 +867,12 @@ class Foo {
...
@@ -867,4 +867,12 @@ class Foo {
checkPreferredItems
1
,
'Intf'
,
'IntfImpl'
checkPreferredItems
1
,
'Intf'
,
'IntfImpl'
}
}
void
testPreferPrintln
()
{
myFixture
.
configureByText
'a.java'
,
'class Foo { { System.out.pri<caret>x } }'
myFixture
.
completeBasic
()
myFixture
.
assertPreferredCompletionItems
0
,
'println'
,
'print'
myFixture
.
type
(
'\t'
)
myFixture
.
checkResult
'class Foo { { System.out.println(<caret>); } }'
}
}
}
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Projects
Groups
Snippets
Help