Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
小 白蛋
Intellij Community
Commits
c8eb903c
Commit
c8eb903c
authored
6 years ago
by
Tagir Valeev
Browse files
Options
Download
Email Patches
Plain Diff
IteratorDeclaration: support parentheses in declaration
parent
b892f425
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
java/java-impl/src/com/intellij/codeInspection/util/IteratorDeclaration.java
+1
-1
...com/intellij/codeInspection/util/IteratorDeclaration.java
java/java-tests/testData/inspection/java8CollectionRemoveIf/beforeIteratorRemoveInline.java
+1
-1
...n/java8CollectionRemoveIf/beforeIteratorRemoveInline.java
with
2 additions
and
2 deletions
+2
-2
java/java-impl/src/com/intellij/codeInspection/util/IteratorDeclaration.java
+
1
-
1
View file @
c8eb903c
...
@@ -102,7 +102,7 @@ public class IteratorDeclaration {
...
@@ -102,7 +102,7 @@ public class IteratorDeclaration {
PsiElement
element
=
declaration
.
getDeclaredElements
()[
0
];
PsiElement
element
=
declaration
.
getDeclaredElements
()[
0
];
if
(!(
element
instanceof
PsiLocalVariable
))
return
null
;
if
(!(
element
instanceof
PsiLocalVariable
))
return
null
;
PsiLocalVariable
variable
=
(
PsiLocalVariable
)
element
;
PsiLocalVariable
variable
=
(
PsiLocalVariable
)
element
;
PsiExpression
initializer
=
variable
.
getInitializer
();
PsiExpression
initializer
=
PsiUtil
.
skipParenthesizedExprDown
(
variable
.
getInitializer
()
)
;
if
(!(
initializer
instanceof
PsiMethodCallExpression
))
return
null
;
if
(!(
initializer
instanceof
PsiMethodCallExpression
))
return
null
;
PsiMethodCallExpression
call
=
(
PsiMethodCallExpression
)
initializer
;
PsiMethodCallExpression
call
=
(
PsiMethodCallExpression
)
initializer
;
if
(!
call
.
getArgumentList
().
isEmpty
())
return
null
;
if
(!
call
.
getArgumentList
().
isEmpty
())
return
null
;
...
...
This diff is collapsed.
Click to expand it.
java/java-tests/testData/inspection/java8CollectionRemoveIf/beforeIteratorRemoveInline.java
+
1
-
1
View file @
c8eb903c
...
@@ -4,7 +4,7 @@ import java.util.List;
...
@@ -4,7 +4,7 @@ import java.util.List;
public
class
Main
{
public
class
Main
{
public
void
testIterator
(
List
<
List
<
String
>>
data
,
boolean
b
)
{
public
void
testIterator
(
List
<
List
<
String
>>
data
,
boolean
b
)
{
for
(
Ite
<
caret
>
rator
<
List
<
String
>>
iter
=
data
.
iterator
();
iter
.
hasNext
();)
{
for
(
Ite
<
caret
>
rator
<
List
<
String
>>
iter
=
(
data
.
iterator
()
)
;
iter
.
hasNext
();)
{
if
(
iter
.
next
().
isEmpty
()
&&
/* also check the flag */
b
)
{
if
(
iter
.
next
().
isEmpty
()
&&
/* also check the flag */
b
)
{
iter
.
remove
();
iter
.
remove
();
}
}
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment