Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
小 白蛋
Intellij Community
Commits
5fe52cc4
Commit
5fe52cc4
authored
6 years ago
by
Roman.Ivanov
Browse files
Options
Download
Email Patches
Plain Diff
Java formatter: skip also spaces before enum for dependant spacing: IDEA-203464, IDEA-204458
parent
ba93dfae
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
java/java-impl/src/com/intellij/psi/formatter/java/JavaSpacePropertyProcessor.java
+1
-1
...tellij/psi/formatter/java/JavaSpacePropertyProcessor.java
java/java-tests/testSrc/com/intellij/java/psi/formatter/java/JavaFormatterTest.kt
+73
-0
...com/intellij/java/psi/formatter/java/JavaFormatterTest.kt
with
74 additions
and
1 deletion
+74
-1
java/java-impl/src/com/intellij/psi/formatter/java/JavaSpacePropertyProcessor.java
+
1
-
1
View file @
5fe52cc4
...
@@ -277,7 +277,7 @@ public class JavaSpacePropertyProcessor extends JavaElementVisitor {
...
@@ -277,7 +277,7 @@ public class JavaSpacePropertyProcessor extends JavaElementVisitor {
private
void
createSpacingForEnumBraces
()
{
private
void
createSpacingForEnumBraces
()
{
// Ignore comments in front of enum for dependent spacing
// Ignore comments in front of enum for dependent spacing
PsiElement
first
=
myParent
.
getFirstChild
();
PsiElement
first
=
myParent
.
getFirstChild
();
while
(
first
instanceof
PsiDocComment
)
{
while
(
first
instanceof
PsiDocComment
||
first
instanceof
PsiWhiteSpace
)
{
first
=
first
.
getNextSibling
();
first
=
first
.
getNextSibling
();
}
}
int
spaces
=
myJavaSettings
.
SPACE_INSIDE_ONE_LINE_ENUM_BRACES
?
1
:
0
;
int
spaces
=
myJavaSettings
.
SPACE_INSIDE_ONE_LINE_ENUM_BRACES
?
1
:
0
;
...
...
This diff is collapsed.
Click to expand it.
java/java-tests/testSrc/com/intellij/java/psi/formatter/java/JavaFormatterTest.kt
+
73
-
0
View file @
5fe52cc4
...
@@ -13,6 +13,7 @@ import com.intellij.psi.JavaCodeFragmentFactory
...
@@ -13,6 +13,7 @@ import com.intellij.psi.JavaCodeFragmentFactory
import
com.intellij.psi.PsiElement
import
com.intellij.psi.PsiElement
import
com.intellij.psi.codeStyle.CodeStyleManager
import
com.intellij.psi.codeStyle.CodeStyleManager
import
com.intellij.psi.codeStyle.CommonCodeStyleSettings
import
com.intellij.psi.codeStyle.CommonCodeStyleSettings
import
com.intellij.psi.codeStyle.CommonCodeStyleSettings.WRAP_ALWAYS
import
com.intellij.testFramework.LightIdeaTestCase
import
com.intellij.testFramework.LightIdeaTestCase
import
com.intellij.testFramework.LightPlatformTestCase
import
com.intellij.testFramework.LightPlatformTestCase
import
com.intellij.util.IncorrectOperationException
import
com.intellij.util.IncorrectOperationException
...
@@ -3684,4 +3685,76 @@ public class Test {
...
@@ -3684,4 +3685,76 @@ public class Test {
)
)
}
}
fun
testIdeaIDEA203464
()
{
getSettings
().
apply
{
ENUM_CONSTANTS_WRAP
=
WRAP_ALWAYS
KEEP_LINE_BREAKS
=
false
}
doTextTest
(
"""
/**
* javadoc
*/
public enum EnumApplyChannel {
C;
public String method() {
return null;
}
}"""
.
trimIndent
(),
"""
/**
* javadoc
*/
public enum EnumApplyChannel {
C;
public String method() {
return null;
}
}"""
.
trimIndent
()
)
}
fun
testIdeaIDEA198408
()
{
getSettings
().
apply
{
ENUM_CONSTANTS_WRAP
=
WRAP_ALWAYS
}
doTextTest
(
"""
/** JavaDoc */
public enum LevelCode {HIGH(3),
MEDIUM(2),
LOW(1);
private final int levelCode;
LevelCode(int levelCode) {
this.levelCode = levelCode;
}
}"""
.
trimIndent
(),
"""
/**
* JavaDoc
*/
public enum LevelCode {
HIGH(3),
MEDIUM(2),
LOW(1);
private final int levelCode;
LevelCode(int levelCode) {
this.levelCode = levelCode;
}
}"""
.
trimIndent
()
)
}
}
}
\ No newline at end of file
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Projects
Groups
Snippets
Help