Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
小 白蛋
Intellij Community
Commits
583a728f
Commit
583a728f
authored
8 years ago
by
Anna.Kozlova
Browse files
Options
Download
Email Patches
Plain Diff
cleanup redundant type arguments
parent
a4214898
Branches unavailable
Tags unavailable
No related merge requests found
Changes
477
Hide whitespace changes
Inline
Side-by-side
Showing
20 changed files
java/compiler/impl/src/com/intellij/compiler/impl/TreeBasedMap.java
+2
-2
...ler/impl/src/com/intellij/compiler/impl/TreeBasedMap.java
java/compiler/impl/src/com/intellij/compiler/impl/javaCompiler/eclipse/EclipseCompiler.java
+1
-1
...j/compiler/impl/javaCompiler/eclipse/EclipseCompiler.java
java/compiler/impl/src/com/intellij/compiler/impl/javaCompiler/javac/JavacCompiler.java
+1
-1
...ellij/compiler/impl/javaCompiler/javac/JavacCompiler.java
java/compiler/impl/src/com/intellij/packaging/impl/artifacts/ArtifactBySourceFileFinderImpl.java
+1
-1
...kaging/impl/artifacts/ArtifactBySourceFileFinderImpl.java
java/compiler/impl/src/com/intellij/packaging/impl/artifacts/ArtifactUtil.java
+1
-1
...c/com/intellij/packaging/impl/artifacts/ArtifactUtil.java
java/compiler/openapi/src/com/intellij/openapi/compiler/CompilationException.java
+1
-1
...c/com/intellij/openapi/compiler/CompilationException.java
java/idea-ui/src/com/intellij/ide/util/importProject/FrameworkDetectionInWizardContext.java
+1
-1
...util/importProject/FrameworkDetectionInWizardContext.java
java/idea-ui/src/com/intellij/ide/util/importProject/LibrariesLayoutPanel.java
+1
-1
...intellij/ide/util/importProject/LibrariesLayoutPanel.java
java/idea-ui/src/com/intellij/ide/util/importProject/ModuleInsight.java
+1
-1
...rc/com/intellij/ide/util/importProject/ModuleInsight.java
java/idea-ui/src/com/intellij/ide/util/importProject/ModulesDetectionStep.java
+1
-1
...intellij/ide/util/importProject/ModulesDetectionStep.java
java/idea-ui/src/com/intellij/ide/util/importProject/ModulesLayoutPanel.java
+1
-1
...m/intellij/ide/util/importProject/ModulesLayoutPanel.java
java/idea-ui/src/com/intellij/ide/util/newProjectWizard/AddSupportForFrameworksPanel.java
+1
-1
...e/util/newProjectWizard/AddSupportForFrameworksPanel.java
java/idea-ui/src/com/intellij/ide/util/newProjectWizard/FrameworkSupportNodeBase.java
+1
-1
...j/ide/util/newProjectWizard/FrameworkSupportNodeBase.java
java/idea-ui/src/com/intellij/ide/util/projectWizard/JavaSettingsStep.java
+1
-1
...com/intellij/ide/util/projectWizard/JavaSettingsStep.java
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/GeneralProjectSettingsElement.java
+5
-2
...roots/ui/configuration/GeneralProjectSettingsElement.java
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/ProjectJdksConfigurable.java
+1
-1
...enapi/roots/ui/configuration/ProjectJdksConfigurable.java
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/nodes/ArtifactRootNode.java
+1
-1
...ts/ui/configuration/artifacts/nodes/ArtifactRootNode.java
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/nodes/PackagingElementNode.java
+1
-1
...i/configuration/artifacts/nodes/PackagingElementNode.java
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/classpath/ClasspathTableModel.java
+1
-1
...roots/ui/configuration/classpath/ClasspathTableModel.java
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/classpath/ProjectStructureChooseLibrariesDialog.java
+1
-1
...tion/classpath/ProjectStructureChooseLibrariesDialog.java
with
25 additions
and
22 deletions
+25
-22
java/compiler/impl/src/com/intellij/compiler/impl/TreeBasedMap.java
+
2
-
2
View file @
583a728f
...
...
@@ -15,8 +15,8 @@
*/
package
com.intellij.compiler.impl
;
import
com.intellij.util.containers.StringInterner
;
import
com.intellij.util.containers.EmptyIterator
;
import
com.intellij.util.containers.StringInterner
;
import
org.jetbrains.annotations.NotNull
;
import
org.jetbrains.annotations.Nullable
;
...
...
@@ -183,7 +183,7 @@ public class TreeBasedMap<T> {
final
HashMap
<
String
,
Node
<
T
>>
childrenMap
=
node
.
myChildren
;
final
boolean
hasChildren
=
childrenMap
!=
null
&&
childrenMap
.
size
()
>
0
;
if
(
hasChildren
||
node
.
mappingExists
())
{
myCurrentNodePath
.
push
(
new
PathElement
<>(
node
,
hasChildren
?
childrenMap
.
keySet
().
iterator
()
:
EmptyIterator
.
<
String
>
getInstance
()));
myCurrentNodePath
.
push
(
new
PathElement
<>(
node
,
hasChildren
?
childrenMap
.
keySet
().
iterator
()
:
EmptyIterator
.
getInstance
()));
if
(
myCurrentNodePath
.
size
()
>
2
)
{
// do not add separator before the Root and its direct child nodes
myCurrentName
.
append
(
mySeparator
);
...
...
This diff is collapsed.
Click to expand it.
java/compiler/impl/src/com/intellij/compiler/impl/javaCompiler/eclipse/EclipseCompiler.java
+
1
-
1
View file @
583a728f
...
...
@@ -57,6 +57,6 @@ public class EclipseCompiler implements BackendCompiler {
@NotNull
@Override
public
Set
<
FileType
>
getCompilableFileTypes
()
{
return
Collections
.
<
FileType
>
singleton
(
StdFileTypes
.
JAVA
);
return
Collections
.
singleton
(
StdFileTypes
.
JAVA
);
}
}
This diff is collapsed.
Click to expand it.
java/compiler/impl/src/com/intellij/compiler/impl/javaCompiler/javac/JavacCompiler.java
+
1
-
1
View file @
583a728f
...
...
@@ -53,6 +53,6 @@ public class JavacCompiler implements BackendCompiler {
@NotNull
public
Set
<
FileType
>
getCompilableFileTypes
()
{
return
Collections
.
<
FileType
>
singleton
(
StdFileTypes
.
JAVA
);
return
Collections
.
singleton
(
StdFileTypes
.
JAVA
);
}
}
This diff is collapsed.
Click to expand it.
java/compiler/impl/src/com/intellij/packaging/impl/artifacts/ArtifactBySourceFileFinderImpl.java
+
1
-
1
View file @
583a728f
...
...
@@ -111,6 +111,6 @@ public class ArtifactBySourceFileFinderImpl extends ArtifactBySourceFileFinder {
}
file
=
file
.
getParent
();
}
return
result
!=
null
?
result
:
Collections
.
<
Artifact
>
emptyList
();
return
result
!=
null
?
result
:
Collections
.
emptyList
();
}
}
This diff is collapsed.
Click to expand it.
java/compiler/impl/src/com/intellij/packaging/impl/artifacts/ArtifactUtil.java
+
1
-
1
View file @
583a728f
...
...
@@ -451,7 +451,7 @@ public class ArtifactUtil {
@NotNull
PackagingElementResolvingContext
context
,
@NotNull
ParentElementProcessor
processor
,
int
maxLevel
)
{
return
processParents
(
artifact
,
context
,
processor
,
FList
.
<
Pair
<
Artifact
,
CompositePackagingElement
<?>>>
emptyList
(),
maxLevel
,
return
processParents
(
artifact
,
context
,
processor
,
FList
.
emptyList
(),
maxLevel
,
new
THashSet
<>());
}
...
...
This diff is collapsed.
Click to expand it.
java/compiler/openapi/src/com/intellij/openapi/compiler/CompilationException.java
+
1
-
1
View file @
583a728f
...
...
@@ -72,7 +72,7 @@ public class CompilationException extends Exception {
}
public
CompilationException
(
String
message
)
{
this
(
message
,
Collections
.
<
Message
>
emptyList
());
this
(
message
,
Collections
.
emptyList
());
}
public
CompilationException
(
String
message
,
Collection
<
Message
>
messages
)
{
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/ide/util/importProject/FrameworkDetectionInWizardContext.java
+
1
-
1
View file @
583a728f
...
...
@@ -62,7 +62,7 @@ public abstract class FrameworkDetectionInWizardContext extends FrameworkDetecti
}
final
List
<
Pair
<
C
,
Collection
<
VirtualFile
>>>
pairs
=
detector
.
createConfigurations
(
filesByModule
.
get
(
module
),
Collections
.
<
C
>
emptyList
());
detector
.
createConfigurations
(
filesByModule
.
get
(
module
),
Collections
.
emptyList
());
for
(
Pair
<
C
,
Collection
<
VirtualFile
>>
pair
:
pairs
)
{
result
.
add
(
new
FacetBasedDetectedFrameworkDescriptionInWizard
<>(
module
,
detector
,
pair
.
getFirst
(),
new
HashSet
<>(
pair
.
getSecond
())));
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/ide/util/importProject/LibrariesLayoutPanel.java
+
1
-
1
View file @
583a728f
...
...
@@ -40,7 +40,7 @@ public class LibrariesLayoutPanel extends ProjectLayoutPanel<LibraryDescriptor>{
protected
List
<
LibraryDescriptor
>
getEntries
()
{
final
List
<
LibraryDescriptor
>
libs
=
getInsight
().
getSuggestedLibraries
();
return
libs
!=
null
?
libs
:
Collections
.
<
LibraryDescriptor
>
emptyList
();
return
libs
!=
null
?
libs
:
Collections
.
emptyList
();
}
protected
Collection
getDependencies
(
final
LibraryDescriptor
entry
)
{
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/ide/util/importProject/ModuleInsight.java
+
1
-
1
View file @
583a728f
...
...
@@ -60,7 +60,7 @@ public abstract class ModuleInsight {
myExistingModuleNames
=
existingModuleNames
;
myExistingProjectLibraryNames
=
existingProjectLibraryNames
;
myProgress
=
new
ProgressIndicatorWrapper
(
progress
);
setRoots
(
Collections
.
<
File
>
emptyList
(),
Collections
.
<
DetectedSourceRoot
>
emptyList
(),
Collections
.
<
String
>
emptySet
());
setRoots
(
Collections
.
emptyList
(),
Collections
.
emptyList
(),
Collections
.
emptySet
());
}
public
final
void
setRoots
(
final
List
<
File
>
contentRoots
,
final
List
<?
extends
DetectedSourceRoot
>
sourceRoots
,
final
Set
<
String
>
ignoredNames
)
{
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/ide/util/importProject/ModulesDetectionStep.java
+
1
-
1
View file @
583a728f
...
...
@@ -104,7 +104,7 @@ public class ModulesDetectionStep extends AbstractStepWithProgress<List<ModuleDe
protected
List
<
ModuleDescriptor
>
calculate
()
{
myInsight
.
scanModules
();
final
List
<
ModuleDescriptor
>
suggestedModules
=
myInsight
.
getSuggestedModules
();
return
suggestedModules
!=
null
?
suggestedModules
:
Collections
.
<
ModuleDescriptor
>
emptyList
();
return
suggestedModules
!=
null
?
suggestedModules
:
Collections
.
emptyList
();
}
@Override
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/ide/util/importProject/ModulesLayoutPanel.java
+
1
-
1
View file @
583a728f
...
...
@@ -48,7 +48,7 @@ public class ModulesLayoutPanel extends ProjectLayoutPanel<ModuleDescriptor>{
protected
List
<
ModuleDescriptor
>
getEntries
()
{
final
List
<
ModuleDescriptor
>
modules
=
getInsight
().
getSuggestedModules
();
return
modules
!=
null
?
modules
:
Collections
.
<
ModuleDescriptor
>
emptyList
();
return
modules
!=
null
?
modules
:
Collections
.
emptyList
();
}
protected
Collection
getDependencies
(
final
ModuleDescriptor
entry
)
{
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/ide/util/newProjectWizard/AddSupportForFrameworksPanel.java
+
1
-
1
View file @
583a728f
...
...
@@ -140,7 +140,7 @@ public class AddSupportForFrameworksPanel implements Disposable {
}
public
void
setProviders
(
List
<
FrameworkSupportInModuleProvider
>
providers
)
{
setProviders
(
providers
,
Collections
.
<
String
>
emptySet
(),
Collections
.
<
String
>
emptySet
());
setProviders
(
providers
,
Collections
.
emptySet
(),
Collections
.
emptySet
());
}
public
void
setProviders
(
List
<
FrameworkSupportInModuleProvider
>
providers
,
Set
<
String
>
associated
,
Set
<
String
>
preselected
)
{
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/ide/util/newProjectWizard/FrameworkSupportNodeBase.java
+
1
-
1
View file @
583a728f
...
...
@@ -81,7 +81,7 @@ public abstract class FrameworkSupportNodeBase<T extends FrameworkOrGroup> exten
@NotNull
public
List
<
FrameworkSupportNodeBase
>
getChildren
()
{
return
children
!=
null
?
(
List
)
children
:
Collections
.
<
FrameworkSupportNodeBase
>
emptyList
();
return
children
!=
null
?
(
List
)
children
:
Collections
.
emptyList
();
}
public
FrameworkSupportNodeBase
getParentNode
()
{
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/ide/util/projectWizard/JavaSettingsStep.java
+
1
-
1
View file @
583a728f
...
...
@@ -98,7 +98,7 @@ public class JavaSettingsStep extends SdkSettingsStep {
}
}
else
{
((
JavaModuleBuilder
)
myModuleBuilder
).
setSourcePaths
(
Collections
.
<
Pair
<
String
,
String
>>
emptyList
());
((
JavaModuleBuilder
)
myModuleBuilder
).
setSourcePaths
(
Collections
.
emptyList
());
}
}
}
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/GeneralProjectSettingsElement.java
+
5
-
2
View file @
583a728f
...
...
@@ -30,7 +30,10 @@ import com.intellij.util.Chunk;
import
org.jetbrains.annotations.NonNls
;
import
org.jetbrains.annotations.NotNull
;
import
java.util.*
;
import
java.util.ArrayList
;
import
java.util.Collections
;
import
java.util.List
;
import
java.util.Set
;
/**
* @author nik
...
...
@@ -104,7 +107,7 @@ public class GeneralProjectSettingsElement extends ProjectStructureElement {
problemsHolder
.
registerProblem
(
new
ProjectStructureProblemDescription
(
message
,
description
,
place
,
ProjectStructureProblemType
.
warning
(
"module-circular-dependency"
),
Collections
.
<
ConfigurationErrorQuickFix
>
emptyList
()));
Collections
.
emptyList
()));
}
}
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/ProjectJdksConfigurable.java
+
1
-
1
View file @
583a728f
...
...
@@ -169,7 +169,7 @@ public class ProjectJdksConfigurable extends MasterDetailsComponent {
selectNodeInTree
(
findNodeByObject
(
myRoot
,
projectJdk
));
});
actions
.
add
(
new
MyActionGroupWrapper
(
group
));
actions
.
add
(
new
MyDeleteAction
(
Conditions
.
<
Object
[]>
alwaysTrue
()));
actions
.
add
(
new
MyDeleteAction
(
Conditions
.
alwaysTrue
()));
return
actions
;
}
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/nodes/ArtifactRootNode.java
+
1
-
1
View file @
583a728f
...
...
@@ -28,7 +28,7 @@ import java.util.Collections;
public
class
ArtifactRootNode
extends
CompositePackagingElementNode
{
public
ArtifactRootNode
(
ArtifactEditorEx
artifactEditor
,
ArtifactEditorContext
context
,
ComplexElementSubstitutionParameters
substitutionParameters
,
ArtifactType
artifactType
)
{
super
(
artifactEditor
.
getRootElement
(),
context
,
null
,
null
,
substitutionParameters
,
Collections
.
<
PackagingNodeSource
>
emptyList
(),
super
(
artifactEditor
.
getRootElement
(),
context
,
null
,
null
,
substitutionParameters
,
Collections
.
emptyList
(),
artifactType
);
}
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/artifacts/nodes/PackagingElementNode.java
+
1
-
1
View file @
583a728f
...
...
@@ -142,7 +142,7 @@ public class PackagingElementNode<E extends PackagingElement<?>> extends Artifac
@NotNull
public
Collection
<
PackagingNodeSource
>
getNodeSource
(
@NotNull
PackagingElement
<?>
element
)
{
final
Collection
<
PackagingNodeSource
>
nodeSources
=
myNodeSources
.
get
(
element
);
return
nodeSources
!=
null
?
nodeSources
:
Collections
.
<
PackagingNodeSource
>
emptyList
();
return
nodeSources
!=
null
?
nodeSources
:
Collections
.
emptyList
();
}
public
ArtifactEditorContext
getContext
()
{
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/classpath/ClasspathTableModel.java
+
1
-
1
View file @
583a728f
...
...
@@ -140,7 +140,7 @@ class ClasspathTableModel extends ListTableModel<ClasspathTableItem<?>> implemen
}
public
void
clear
()
{
setItems
(
Collections
.
<
ClasspathTableItem
<?>>
emptyList
());
setItems
(
Collections
.
emptyList
());
}
private
List
<
OrderEntry
>
getEntries
()
{
...
...
This diff is collapsed.
Click to expand it.
java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/classpath/ProjectStructureChooseLibrariesDialog.java
+
1
-
1
View file @
583a728f
...
...
@@ -70,7 +70,7 @@ public class ProjectStructureChooseLibrariesDialog extends ChooseLibrariesFromTa
@Override
public
void
doCancelAction
()
{
super
.
doCancelAction
();
removeCreatedModuleLibraries
(
Collections
.
<
Library
>
emptyList
());
removeCreatedModuleLibraries
(
Collections
.
emptyList
());
}
private
void
removeCreatedModuleLibraries
(
Collection
<
Library
>
selected
)
{
...
...
This diff is collapsed.
Click to expand it.
Prev
1
2
3
4
5
…
24
Next
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Projects
Groups
Snippets
Help