IDEA-139173 PresentationAnnotationInspection testdata fixes + minor improvements

plugins/devkit/src/inspections/PresentationAnnotationInspection.java

@@ -43,7 +43,7 @@ public class PresentationAnnotationInspection extends DevKitUastInspectionBase {
           return;
         }
 
-        UExpression iconExpression = annotation.findAttributeValue("icon");
+        UExpression iconExpression = annotation.findDeclaredAttributeValue("icon");
         if (iconExpression == null) {
           return;
         }
@@ -53,9 +53,6 @@ public class PresentationAnnotationInspection extends DevKitUastInspectionBase {
           LOG.error("Unexpected null value of @Presentation#icon expression PSI: " + element);
           return;
         }
-        if (!iconExpressionPsi.isPhysical()) {
-          return;
-        }
 
         PsiReference[] references = iconExpressionPsi.getReferences();
         for (PsiReference reference : references) {

plugins/devkit/testData/inspections/presentation/AbsentIconParam.java

+import com.intellij.ide.presentation.Presentation;
+
+@Presentation(typeName = "TypeName")
+public class AbsentIconParam {
+}
\ No newline at end of file

plugins/devkit/testData/inspections/presentation/InvalidIcon.java

 import com.intellij.ide.presentation.Presentation;
 
-@Presentation(icon = "<error descr="Cannot resolve symbol 'InvalidIconPath'">InvalidIconPath</error>")
+@Presentation(icon = "<error descr="Cannot resolve icon 'InvalidIconPath'">InvalidIconPath</error>")
 class InvalidIcon {
 }
 
-@Presentation(icon = "<error descr="Cannot resolve symbol ''"></error>")
+@Presentation(icon = "<error descr="Cannot resolve icon ''"></error>")
 class EmptyIcon {
 }
\ No newline at end of file

plugins/devkit/testSources/inspections/PresentationAnnotationInspectionTest.java

@@ -64,4 +64,8 @@ public class PresentationAnnotationInspectionTest extends JavaCodeInsightFixture
   public void testInvalidIcon() {
     myFixture.testHighlighting("InvalidIcon.java");
   }
+
+  public void testForAbsentIconParam() {
+    myFixture.testHighlighting("AbsentIconParam.java");
+  }
 }
\ No newline at end of file