Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • I Incubator Kyuubi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • 小 白蛋
  • Incubator Kyuubi
  • Repository
Switch branch/tag
  • incubator-kyuubi
  • externals
  • kyuubi-spark-sql-engine
  • pom.xml
Find file BlameHistoryPermalink
  • Kent Yao's avatar
    [KYUUBI #471] Separate Embedded Zookeeper server from ha · c6585b47
    Kent Yao authored Mar 30, 2021
    ![yaooqinn](https://badgen.net/badge/Hello/yaooqinn/green) [![Closes #471](https://badgen.net/badge/Preview/Closes%20%23471/blue)](https://github.com/yaooqinn/kyuubi/pull/471) ![386](https://badgen.net/badge/%2B/386/red) ![152](https://badgen.net/badge/-/152/green) ![8](https://badgen.net/badge/commits/8/yellow) ![Target Issue](https://badgen.net/badge/Missing/Target%20Issue/ff0000) [<img width="16" alt="Powered by Pull Request Badge" src="https://user-images.githubusercontent.com/1393946/111216524-d2bb8e00-85d4-11eb-821b-ed4c00989c02.png">](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT -->
    
    <!--
    Thanks for sending a pull request!
    
    Here are some tips for you:
      1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
      2. If the PR is related to an issue in https://github.com/yaooqinn/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
      3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
    -->
    
    ### _Why are the changes needed?_
    <!--
    Please clarify why the changes are needed. For instance,
      1. If you add a feature, you can talk about the use case of it.
      2. If you fix a bug, you can clarify why it is a bug.
    -->
    
    1. Separated embedded zk from ha module, as it's only used for setup a zk from Kyuubi server for now if there is not an external one
    2. Support more configuration for the embedded zookeeper, for example, HOSTNAME, then it's more close to prod usage.
    3. TODO: Make the embedded zookeeper of our own, which should support as quorum peers
    
    ### _How was this patch tested?_
    - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests
    
    ) locally before make a pull request
    
    Closes #471 from yaooqinn/qp.
    
    Closes #471
    
    1c24d02 [Kent Yao] address comments
    9666a40 [Kent Yao] refine
    f069fc0 [Kent Yao] refine
    8bb2f3a [Kent Yao] refine
    c20593a [Kent Yao] refine
    8fa9a40 [Kent Yao] Merge branch 'master' into qp
    1e2e1a3 [Kent Yao] tmp
    7d66d05 [Kent Yao] tmp
    Authored-by: default avatarKent Yao <yao@apache.org>
    Signed-off-by: default avatarKent Yao <yao@apache.org>
    c6585b47

免费DevSecOps平台,让您的项目体验完整的DevSecOps流程,让项目更安全