Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • I Incubator Kyuubi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • 小 白蛋
  • Incubator Kyuubi
  • Repository
Switch branch/tag
  • incubator-kyuubi
  • NOTICE
Find file BlameHistoryPermalink
  • Cheng Pan's avatar
    [KYUUBI #622] [NOTICE] Add NOTICE · d3e2981f
    Cheng Pan authored May 07, 2021
    <!--
    Thanks for sending a pull request!
    
    Here are some tips for you:
      1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
      2. If the PR is related to an issue in https://github.com/NetEase/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
      3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
    -->
    
    ### _Why are the changes needed?_
    <!--
    Please clarify why the changes are needed. For instance,
      1. If you add a feature, you can talk about the use case of it.
      2. If you fix a bug, you can clarify why it is a bug.
    -->
    Add `NOTICE` file in this PRs.
    
    Have a look on other projects, I only see Apache Spark maintains `NOTICE-binary` in repo, most projects generate it on build process.
    
    For instance,
    
    Apache Flink use shell [`collect_license_files`](https://github.com/apache/flink/blob/release-1.13.0/tools/releasing/collect_license_files.sh) to collect LICENSE and NOTICE files.
    Apache Calcite use gradle plugin [vlsi-release-plugins](https://github.com/vlsi/vlsi-release-plugins)  to manage the whole release process, see [build.gradle.kts](https://github.com/apache/calcite/blob/calcite-1.26.0/build.gradle.kts#L45).
    Apache Kafka write gradle scripts to gather LICENSE and NOTICE files, see [build.gradle](https://github.com/apache/kafka/blob/2.8.0/build.gradle).
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests
    
    ) locally before make a pull request
    
    Closes #622 from pan3793/notice.
    
    Closes #622
    
    777ca699 [Cheng Pan] [NOTICE] Add NOTICE
    Authored-by: default avatarCheng Pan <379377944@qq.com>
    Signed-off-by: default avatarCheng Pan <379377944@qq.com>
    d3e2981f

免费DevSecOps平台,让您的项目体验完整的DevSecOps流程,让项目更安全