A chart being installed which only contains CRDs and not
any templates tries to install the resources by default.
The resourceList which is used in this case does not check
if there are resources present in it or not. This commit
adds checks to those particular places where we need to check
if the size of resourceList > 0 during installation and deletion.
Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
(cherry picked from commit 47abe66f)
(cherry picked from commit fe51cd1e)

1. fixed capitalization in a few help messages
2. use no thrid-person verb.

ref #7898
Signed-off-by: Liu Ming <hit_oak_tree@126.com>
(cherry picked from commit bc515991)
(cherry picked from commit 9036e17f)

Signed-off-by: Liu Ming <hit_oak_tree@126.com>
(cherry picked from commit ff3ed53b)
(cherry picked from commit 07255156)

The tables aren't rendered correctly because the syntax was wrong. Fixed it by applying the https://www.markdownguide.org/extended-syntax/#tables table syntax.

See https://helm.sh/docs/helm/helm/#synopsis for the wrong rendering.

![Broken table in html](https://imgur.com/bniKxO6

)

Fix for helm/helm-www#575
Signed-off-by: Lüchinger Dominic <dev@snowgarden.ch>
(cherry picked from commit fb829c2c)
(cherry picked from commit 8635a196)

Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
(cherry picked from commit 6bc4a948)
(cherry picked from commit 03a4c06a)

In the created chart from `helm create` is notes a tag overrides
version. It actually overrides appVersion. Updating the docs
to reflect reality.
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 54e5088a)
(cherry picked from commit 209974ad)

* return the new values if modifications dont yet exist
Signed-off-by: David Pait <DP19@users.noreply.github.com>

* fix tests
Signed-off-by: David Pait <DP19@users.noreply.github.com>

* removed outter if statement as its not needed now
Signed-off-by: David Pait <DP19@users.noreply.github.com>
(cherry picked from commit 6aefbdcf)
(cherry picked from commit efad4071)

Copy plugins from the cache rather than create a symlink.

fixes: #7206
Signed-off-by: Adam Reese <adam@reese.io>
(cherry picked from commit 1cdd0a20)
(cherry picked from commit 48d09a26)

fs_test: use os.Getuid() instead user.Current() to determine if a test is executed with root privileges.

This change lower the expectations on test env setup, i.e. tests could be executed in a container under a random UID,
without require an user in /etc/passwd
Signed-off-by: Predrag Knezevic <pknezevi@redhat.com>
(cherry picked from commit b83d3d41)
(cherry picked from commit b98b7d06)

Signed-off-by: Matt Morrissette <yinzara@gmail.com>
(cherry picked from commit 19118709)
(cherry picked from commit 56ef9ab3)

Signed-off-by: Matt Farina <matt@mattfarina.com>

If stat returns an error other than the directory not existing
it was unhandled. When IsDir is called in one of these situations
it causes a panic.

Closes #8181
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit f182ebc1)

Having both the `showCmd` and the `subCmd` passed to `addShowFlags()`
can easily lead to mistakes in using the wrong command.
Instead, `addShowFlags()` should only focus on the `subCmd`
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
(cherry picked from commit 7dec5dcb)

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
(cherry picked from commit 5600a2c8)

Fix `repo add` and `repo update` to use a repository cache set
using `--repository-cache` flag
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Signed-off-by: Trond Hindenes <trond@hindenes.com>
(cherry picked from commit 2ae83f27)

* Fixing issue with PAX headers in plugin archive

PAX Headers can be added by some systems that create archives. Helm
should ignore them when extracting.

There are two PAX headers. One is global and the other is not. Both
are ignored. The test adds only the PAX global header because the
Go tar package is unable to write the header that is not global.

Closes #8084
Signed-off-by: Matt Farina <matt@mattfarina.com>

* Removing the PAX header test as it is not working

The PAX header test was making a WriteHeader call and ignoring the
error. When writing the type TypeXHeader it was causing an error
that was being silently ignored. The Go tar package cannot write
this type and produces an error when one tries to. The error reads
"cannot manually encode TypeXHeader, TypeGNULongName, or TypeGNULongLink
headers"
Signed-off-by: Matt Farina <matt@mattfarina.com>

* Adding check of returned error in test

Adding a check for the returned error to make sure a non-nil value
is not returned.
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 512544b9)

fix helm/helm#7999
Signed-off-by: Liu Ming <hit_oak_tree@126.com>
(cherry picked from commit decab8ea)

Signed-off-by: Idan Elhalwani <idan@elhalwani.com>
(cherry picked from commit 93b0eee0)

* fix: write index.yaml file atomically

This refactors the already-existing `AtomicWriteFile` utility
to a central location and uses it to write index files
atomically.
This is done to avoid having half-written index files break
client requests.

Drive-bys:
  - Add test for AtomicWriteFile.
  - Add test IndexFile.WriteFile.
Signed-off-by: rabadin <rvbadin@gmail.com>

* Review fix: use RenameWithFallback instead of os.Rename
Signed-off-by: rabadin <rvbadin@gmail.com>
Co-authored-by: rabadin <rvbadin@gmail.com>

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
(cherry picked from commit bb47286f)

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* Migrate SQL storage driver to Helm 3
Signed-off-by: Elliot Maincourt <e.maincourt@gmail.com>

* Update pkg/storage/driver/sql.go
Co-Authored-By: Sebastian Pöhn <sebastian.poehn@gmail.com>
Signed-off-by: Elliot Maincourt <e.maincourt@gmail.com>

* Add authentication to releases_v3
Signed-off-by: Elliot Maincourt <e.maincourt@gmail.com>

* Fix migration
Signed-off-by: Elliot Maincourt <e.maincourt@gmail.com>

* Template the init migration
Signed-off-by: Elliot Maincourt <e.maincourt@gmail.com>

* Prevent potential SQL injection
Signed-off-by: Elliot Maincourt <e.maincourt@gmail.com>

* Use an SQL querybuilder
Signed-off-by: Elliot Maincourt <e.maincourt@gmail.com>

* Remove references to HELM_DRIVER_SQL_DIALECT
Signed-off-by: Elliot Maincourt <e.maincourt@gmail.com>
Co-authored-by: Sebastian Pöhn <sebastian.poehn@gmail.com>
Co-authored-by: Matt Butcher <matt.butcher@microsoft.com>

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

Updating sprig and semver to newer versions

* Fix nested null value overrides
Signed-off-by: Mingxiang Xue <mingxiangxue@gmail.com>

* Fix subchart value deletion
Signed-off-by: Mingxiang Xue <mingxiangxue@gmail.com>

Note, there is an issue with a dependency of sprig changing
behavior. A test has been added with a description to catch if a
behavior breaking change of mergo is used.

See https://github.com/imdario/mergo/issues/139

 for the mergo
issue and sprig for further details on handling this in the
future.

Closes  #7533
Signed-off-by: Matt Farina <matt@mattfarina.com>

Add unit test for function FindPlugins

Signed-off-by: ZouYu <zouy.fnst@cn.fujitsu.com>

* fix: rebuild chart after dependency update on install
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* add correct debug settings
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

* Make get script eaiser for helm versions to live side by side (helm3 etc)
Signed-off-by: Scott Rigby <scott@r6by.com>

* Change PROJECT_NAME to BINARY_NAME for purpose clarity
Signed-off-by: Scott Rigby <scott@r6by.com>

fix(upgrade): Add an improved user error message for removed Kubernetes APIs

Signed-off-by: Riccardo Piccoli <riccardo.piccoli@softonic.com>
Co-authored-by: Riccardo Piccoli <riccardo.piccoli@softonic.com>

Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

fix(helm): stdin values for helm upgrade --install

The error message returned from Kubernetes when APIs are
removed is not very informative. This PR adds additional
information to the user. It covers the current release manifest
APIs.

Partial #7219
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

Make helm create command's templates more consistent

Avoid downloading the same chart multiple times

* test(pkg/storage/secrets): make MockSecretsInterface.List follow ListOptions
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

* test(pkg/storage/secrets): add unit test for Secrets.Query
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

* test(pkg/storage/cfgmaps): make MockConfigMapsInterface.List follow ListOptions
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

* test(pkg/storage/cfgmaps): add unit test for ConfigMaps.Query
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>