This happened to be a bug we identified in Helm 3 and did not check if
it existed in Helm 2. The improved logic for job waiting used an automatic
retry. However, when we were creating the watcher, we were listing on everything
of that same api version and kind. So if you had more than 1 hook and the first
was successful, it would think everything was successful. I have validated that
this now fails as intended if a job is failing

Closes #6767
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>

fix(kube): Fixes missing API versions

In several of the job checks and other conversions we were using legacyscheme.
I don't know why it was working before, but I am guessing something changed
between k8s 1.15 and 1.16. To fix I changed the references to use the default
scheme in client-go
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>

bump version to v2.16.0-rc.1

Support cross device rename

Signed-off-by: Matt Farina <matt@mattfarina.com>

Update language on search usage

This is a followup to PR #6780 that implements some discussed
language changes.
Signed-off-by: Matt Farina <matt@mattfarina.com>

fix(repo/search): fix helm repo search command to display proper versions

Fix error when loading irregular files

Signed-off-by: Matt Farina <matt@mattfarina.com>

ref(glide.yaml): kubernetes 1.16.2

Signed-off-by: Adam Reese <adam@reese.io>

Signed-off-by: Adam Reese <adam@reese.io>

Signed-off-by: Adam Reese <adam@reese.io>

fix(wait): Removes ingress checks

Closes #6751

After doing some more digging, I found out that updating the status
of an `Ingress` object is completely optional. Because of this, Helm
cannot support ingresses with the `--wait` flag because there is no
standard way to identify that they are ready
Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>

Introduce the `--devel` flag for `helm repo search` command.

`helm repo search` - searches only for stable releases, prerelease versions will be skip
`helm repo search --devel` - searches for releases and prereleases (alpha, beta, and release candidate releases)
`helm repo search --version 1.0.0 - searches for release in version 1.0.0
Signed-off-by: Mateusz Szostok <szostok.mateusz@gmail.com>

fix silent lint ignore for non existing packaged charts

Update to the checklist of things encountered during patch release.
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

Signed-off-by: Karuppiah Natarajan <karuppiah7890@gmail.com>

fix(sympath): walk symbolic links one once

Reverted changes introduced in #6010

This commit reverts changes introduced in #6010 due to a massive
regression reported in #6708. An attempt to fix the problem in
https://github.com/helm/helm/pull/6709 seems to be unreasonably clumzy
and hacky, therefore reverting the offensive change seems to be the most
pragmatic solution.

This reverts commits:
  * 70cd32c4.
  * 9014bd9c

.
Signed-off-by: Oleg Sidorov <me@whitebox.io>

Signed-off-by: Yagnesh Mistry <ysh@live.in>

Signed-off-by: Yagnesh Mistry <ysh@live.in>

Signed-off-by: Yagnesh Mistry <ysh@live.in>

Signed-off-by: Brice Rising <brice.rising@slalom.com>

Signed-off-by: Brice Rising <brice.rising@slalom.com>

Signed-off-by: Brice Rising <brice.rising@slalom.com>

I found another package that took code from a BSD licensed open source project. I copied their approach for reusing that license.
Signed-off-by: Brice Rising <brice.rising@slalom.com>

This is probably not the correct apporach to using bsd licensed code under an apache license.
Signed-off-by: Brice Rising <brice.rising@slalom.com>

For some reason, gofmt -s -w produced a different result than running gofmt on my host os
Signed-off-by: Brice Rising <brice.rising@slalom.com>

Neeted to run formatting on fs_test.go
Signed-off-by: Brice Rising <brice.rising@slalom.com>

Unused var was in fs.go. Removed it.
Signed-off-by: Brice Rising <brice.rising@slalom.com>

Our style settings don't like underscores in variable names, so I switched to camel case. Also, err was unused in some places, so I made an error a fail condition for some test.
Signed-off-by: Brice Rising <brice.rising@slalom.com>

Root can access all files, so the tests for inaccessible files were failing. Now we will skip these tests when running as root.
Signed-off-by: Brice Rising <brice.rising@slalom.com>

Recreated the features of the test package in dep that were necessary to run the tests in the fs package.
Signed-off-by: Brice Rising <brice.rising@slalom.com>

The fs package tests are going to be a lot of work to get working without the internal test package used by golang/dep, so I removed all of the unused ones by this project to make the work easier.
Signed-off-by: Brice Rising <brice.rising@slalom.com>

helm dependency upgrade wasn't working on certain file system because it assumes that os.rename is available. Since rename isn't available for subfolders in docker containers, I ripped a fallback rename strategy from dep (https://github.com/golang/dep/blob/5b1fe9e6d89372487d0aac78d9c5362a517857e7/internal/fs/fs.go#L103-L118

) that works in docker.
Signed-off-by: Brice Rising <brice.rising@slalom.com>