Unverified Commit 7ff36307 authored by René Dudfield's avatar René Dudfield Committed by GitHub
Browse files

Merge pull request #545 from kinvolk/fix-windows-quit

app: Kill Headlamp server process synchronously
parents 28cc01bd d8bbf179
xterm-windows-mode action-button-improvements add-cluster-to-notification-area add-direct-c-o-c add-fullscreen-to-editor add-labs add-msi-installer add-notification-page add-ports-to-pods add-proxy-endpoint add_manual_trigger_docker_action allow-to-build-without-checking-for-updates app-menus apply-multiple-resources autoscalers_resource_quota backend-dependencies bump-chocolatey-0.13.0 center-cluster-chooser chart-0.10.1 choco-bump-0.12.1 cluster_chooser codegen config_from_env de-de dep-updates2 dependabot/npm_and_yarn/app/electron-15.5.5 dependabot/npm_and_yarn/frontend/d3-color-and-recharts-3.1.0 dependabot/npm_and_yarn/frontend/deep-object-diff-1.1.9 dependabot/npm_and_yarn/frontend/loader-utils-1.4.2 dependabot/npm_and_yarn/frontend/terser-4.8.1 dependabot/npm_and_yarn/plugins/examples/app-menus/terser-5.14.2 dependabot/npm_and_yarn/plugins/examples/change-logo/glob-parent-and-kinvolk/headlamp-plugin-5.1.2 dependabot/npm_and_yarn/plugins/examples/change-logo/terser-5.14.2 dependabot/npm_and_yarn/plugins/examples/cluster-chooser/glob-parent-and-kinvolk/headlamp-plugin-5.1.2 dependabot/npm_and_yarn/plugins/examples/cluster-chooser/terser-5.14.2 dependabot/npm_and_yarn/plugins/examples/dynamic-clusters/glob-parent-and-kinvolk/headlamp-plugin-5.1.2 dependabot/npm_and_yarn/plugins/examples/dynamic-clusters/terser-5.14.2 dependabot/npm_and_yarn/plugins/examples/sidebar/terser-5.14.2 dependabot/npm_and_yarn/plugins/headlamp-plugin/terser-5.14.2 docker_desktop_ext docs-allow-to-build-without-checking-for-updates dont-use-a-one-click-installer-on-windows dont-wrap-header-cells e2e-container e2e-login e2e-playwright endpoints errcb-fix event-sorting example-fixes export-charts export-resource-chart-and-lib fetch-pods-by-labels fix-applying-ingresses fix-cluster-chooser fix-crash-in-label-selector fix-default-page-rows fix-filter-when-items-are-numbers fix-issue-in-page-grid-children-type fix-navigating-during-delete-op fix-quitting-server-again fix-release-note-stuck-issue fix-simple-table fix-table-filter fix-unexpected-null-in-getOwnedPods fix_manual_trigger_gh_action fr-fr fullscreen_dialog gh_action_automate_pr go-back-through-location-stack handle-custom-auth-desktop headlamp-plugin-0.5.1-b headlamp-plugin-0.5.2-b headlamp-plugin-upgrade headlamp-upgrade-audit helm-fixes helm-typo-docs-fix hide-appbar improve-app-menus improve-pod-matcher improve-pod-status inno-setup jrocha/wip/show-build-version localefix log-viewer-scroll-fix mui-v5-upgrade namespaces-filter new-k8s-secret no-cluster-no-auth-required notification-clear-and-all-read optimize-use-get persist-url-params plugin-docs plugin-error-handling plugin-source plugin-tests-in-js port-forwarding push-asset rc-0.10.0 rc-0.10.1 rc-0.11.0 rc-0.11.1 rc-0.12.0 rc-0.12.1 rc-0.13.0 refresh_token remove-plugin-video render-logs-using-xterm resource-class-issue resources-json role_bind_info scaling-ui search-involved-object-type-events-table set-default-namespace shorter-resource-age show-build-version show-dialog-if-release-fetch-failed sidebarroutefilter simple-table-details-from-url simplify-testing test-cleanup update-examples-052 update-release-draft update-signing-email upgrade-new-things use-fixed-date-on-tests wait-for-plugins width-cosmetic-fixes windows-testing v0.13.0 v0.12.1 v0.12.0 v0.11.1 v0.11.0 v0.10.1 v0.10.0 headlamp-plugin-0.5.3 headlamp-plugin-0.5.2 headlamp-plugin-0.5.1 headlamp-plugin-0.5.0 headlamp-plugin-0.4.9 headlamp-helm-0.8.0 headlamp-helm-0.7.0 headlamp-helm-0.6.0 headlamp-helm-0.5.0 headlamp-helm-0.4.0
No related merge requests found
Showing with 2 additions and 2 deletions
+2 -2
import { ChildProcessWithoutNullStreams, exec, spawn } from 'child_process';
import { ChildProcessWithoutNullStreams, execSync, spawn } from 'child_process';
import { app, BrowserWindow, ipcMain, Menu, MenuItem, screen, shell } from 'electron';
import { IpcMainEvent, MenuItemConstructorOptions } from 'electron/main';
import log from 'electron-log';
......@@ -97,7 +97,7 @@ function quitServerProcess() {
process.kill(-serverProcess.pid);
} else if (process.platform === 'win32' && serverProcess) {
// Otherwise on Windows the process will stick around.
exec('taskkill /pid ' + serverProcess.pid + ' /T /F');
execSync('taskkill /pid ' + serverProcess.pid + ' /T /F');
}
serverProcess.stdin.destroy();
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment