chore: Change installation manifests to pull images from quay.io (#5227)

* chore: Update manifests to point to quay.io
Signed-off-by: jannfis <jann@mistrust.net>

* Set image also in kustomize bases
Signed-off-by: jannfis <jann@mistrust.net>

* make manifests
Signed-off-by: jannfis <jann@mistrust.net>

* Also update for Dex init container
Signed-off-by: jannfis <jann@mistrust.net>

* Adapt upgrade docs to reflect new registry
Signed-off-by: jannfis <jann@mistrust.net>

docs/operator-manual/upgrading/1.8-1.9.md

@@ -16,3 +16,20 @@ tools in custom-built images.
 Please make sure that your custom tools are still working with the update to
 v1.9 before deploying it onto production.
 
+## Container registry switched to quay.io and sundown of Docker Hub repository
+
+Due to Docker Hub's new rate-limiting and retention policies, the Argo project
+has decided to switch to the
+[quay.io](https://quay.io)
+registry as a new home for all images published by its sub-projects.
+
+As of Argo CD version 1.9, the installation manifests are configured to pull the
+container images from `quay.io` and we announce the **sundown** of the existing
+Docker Hub repositories. For the 1.9 release this means, we will still push to
+both registries, but we will stop pushing images to Docker Hub once Argo CD 1.10
+has been released.
+
+Please make sure that your clusters can pull from the `quay.io` registry.
+If you aren't able to do so timely, you can change the container image slugs in
+the installation manually to Docker Hub as a workaround to install Argo CD 1.9.
+This workaround will not be possible anymore with 1.10, however.

hack/update-manifests.sh

@@ -11,7 +11,7 @@ AUTOGENMSG="# This is an auto-generated file. DO NOT EDIT"
 
 cd ${SRCROOT}/manifests/ha/base/redis-ha && ./generate.sh
 
-IMAGE_NAMESPACE="${IMAGE_NAMESPACE:-argoproj}"
+IMAGE_NAMESPACE="${IMAGE_NAMESPACE:-quay.io/argoproj}"
 IMAGE_TAG="${IMAGE_TAG:-}"
 
 # if the tag has not been declared, and we are on a release branch, use the VERSION file.
@@ -29,8 +29,8 @@ fi
 
 $KUSTOMIZE version
 
-cd ${SRCROOT}/manifests/base && $KUSTOMIZE edit set image argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG}
-cd ${SRCROOT}/manifests/ha/base && $KUSTOMIZE edit set image argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG}
+cd ${SRCROOT}/manifests/base && $KUSTOMIZE edit set image quay.io/argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG}
+cd ${SRCROOT}/manifests/ha/base && $KUSTOMIZE edit set image quay.io/argoproj/argocd=${IMAGE_NAMESPACE}/argocd:${IMAGE_TAG}
 
 echo "${AUTOGENMSG}" > "${SRCROOT}/manifests/install.yaml"
 $KUSTOMIZE build "${SRCROOT}/manifests/cluster-install" >> "${SRCROOT}/manifests/install.yaml"

manifests/base/application-controller/argocd-application-controller-statefulset.yaml

@@ -24,7 +24,7 @@ spec:
         - "20"
         - --operation-processors
         - "10"
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         name: argocd-application-controller
         ports:

manifests/base/dex/argocd-dex-server-deployment.yaml

@@ -18,7 +18,7 @@ spec:
       serviceAccountName: argocd-dex-server
       initContainers:
       - name: copyutil
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         command: [cp, -n, /usr/local/bin/argocd-util, /shared]
         volumeMounts:

manifests/base/kustomization.yaml

@@ -3,8 +3,8 @@ kind: Kustomization
 
 
 images:
-- name: argoproj/argocd
-  newName: argoproj/argocd
+- name: quay.io/argoproj/argocd
+  newName: quay.io/argoproj/argocd
   newTag: latest
 resources:
 - ./application-controller

manifests/base/repo-server/argocd-repo-server-deployment.yaml

@@ -18,7 +18,7 @@ spec:
       automountServiceAccountToken: false
       containers:
       - name: argocd-repo-server
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         command:
         - uid_entrypoint.sh

manifests/base/server/argocd-server-deployment.yaml

@@ -18,7 +18,7 @@ spec:
       serviceAccountName: argocd-server
       containers:
       - name: argocd-server
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         command: [argocd-server, --staticassets, /shared/app]
         volumeMounts:

manifests/ha/base/kustomization.yaml

@@ -9,8 +9,8 @@ patchesStrategicMerge:
 
 
 images:
-- name: argoproj/argocd
-  newName: argoproj/argocd
+- name: quay.io/argoproj/argocd
+  newName: quay.io/argoproj/argocd
   newTag: latest
 resources:
 - ../../base/application-controller

manifests/ha/install.yaml

@@ -2874,7 +2874,7 @@ spec:
         - -n
         - /usr/local/bin/argocd-util
         - /shared
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         name: copyutil
         volumeMounts:
@@ -3012,7 +3012,7 @@ spec:
         - argocd-repo-server
         - --redis
         - argocd-redis-ha-haproxy:6379
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           failureThreshold: 3
@@ -3094,7 +3094,7 @@ spec:
         env:
         - name: ARGOCD_API_SERVER_REPLICAS
           value: "2"
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           httpGet:
@@ -3170,7 +3170,7 @@ spec:
         - "10"
         - --redis
         - argocd-redis-ha-haproxy:6379
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           httpGet:

manifests/ha/namespace-install.yaml

@@ -2789,7 +2789,7 @@ spec:
         - -n
         - /usr/local/bin/argocd-util
         - /shared
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         name: copyutil
         volumeMounts:
@@ -2927,7 +2927,7 @@ spec:
         - argocd-repo-server
         - --redis
         - argocd-redis-ha-haproxy:6379
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           failureThreshold: 3
@@ -3009,7 +3009,7 @@ spec:
         env:
         - name: ARGOCD_API_SERVER_REPLICAS
           value: "2"
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           httpGet:
@@ -3085,7 +3085,7 @@ spec:
         - "10"
         - --redis
         - argocd-redis-ha-haproxy:6379
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           httpGet:

manifests/install.yaml

@@ -2465,7 +2465,7 @@ spec:
         - -n
         - /usr/local/bin/argocd-util
         - /shared
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         name: copyutil
         volumeMounts:
@@ -2565,7 +2565,7 @@ spec:
         - argocd-repo-server
         - --redis
         - argocd-redis:6379
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           failureThreshold: 3
@@ -2643,7 +2643,7 @@ spec:
         - argocd-server
         - --staticassets
         - /shared/app
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           httpGet:
@@ -2718,7 +2718,7 @@ spec:
         - "20"
         - --operation-processors
         - "10"
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           httpGet:

manifests/namespace-install.yaml

@@ -2380,7 +2380,7 @@ spec:
         - -n
         - /usr/local/bin/argocd-util
         - /shared
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         name: copyutil
         volumeMounts:
@@ -2480,7 +2480,7 @@ spec:
         - argocd-repo-server
         - --redis
         - argocd-redis:6379
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           failureThreshold: 3
@@ -2558,7 +2558,7 @@ spec:
         - argocd-server
         - --staticassets
         - /shared/app
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           httpGet:
@@ -2633,7 +2633,7 @@ spec:
         - "20"
         - --operation-processors
         - "10"
-        image: argoproj/argocd:latest
+        image: quay.io/argoproj/argocd:latest
         imagePullPolicy: Always
         livenessProbe:
           httpGet: