Unverified Commit e44d5e0b authored by Emma Broman's avatar Emma Broman Committed by GitHub
Browse files

Disable hover circle per default when setting renderable (fixes #2153)

and throw warning if setting to non-existing node
Showing with 9 additions and 0 deletions
+9 -0
......@@ -307,6 +307,9 @@ void SkyBrowserModule::lookAtTarget(const std::string& id) {
void SkyBrowserModule::setHoverCircle(SceneGraphNode* circle) {
_hoverCircle = circle;
// Always disable it per default. It should only be visible on interaction
disableHoverCircle();
}
void SkyBrowserModule::moveHoverCircle(int i, bool useScript) {
......
......@@ -87,6 +87,12 @@ namespace {
using namespace openspace;
SceneGraphNode* circle = global::renderEngine->scene()->sceneGraphNode(identifier);
if (!circle) {
throw ghoul::lua::LuaError(fmt::format(
"Could not find node to set as hover circle: '{}'", identifier
));
}
global::moduleEngine->module<SkyBrowserModule>()->setHoverCircle(circle);
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment