"src/carnot/planner/rules/rules_test.cc" did not exist on "fc24d413a8a775c1092e1d7bd4fe9f1bd3efe150"
  • M. Mert Yıldıran's avatar
    Refactor `tap` module to achieve synchronously closing other protocol... · d3e6a69d
    M. Mert Yıldıran authored
    Refactor `tap` module to achieve synchronously closing other protocol dissectors upon identification (#1026)
    
    * Remove `tcpStreamWrapper` struct
    
    * Refactor `tap` module and move some of the code to `tap/api` module
    
    * Move `TrafficFilteringOptions` struct to `shared` module
    
    * Change the `Dissect` method signature to have `*TcpReader` as an argument
    
    * Add `CloseOtherProtocolDissectors` method and use it to synchronously close the other protocol dissectors
    
    * Run `go mod tidy` in `cli` module
    
    * Rename `SuperIdentifier` struct to `ProtoIdentifier`
    
    * Remove `SuperTimer` struct
    
    * Bring back `CloseTimedoutTcpStreamChannels` method
    
    * Run `go mod tidy` everywhere
    
    * Remove `GOGC` environment variable from tapper
    
    * Fix the tests
    
    * Bring back `debug.FreeOSMemory()` call
    
    * Make `CloseOtherProtocolDissectors` method mutexed
    
    * Revert "Remove `GOGC` environment variable from tapper"
    
    This reverts commit cfc2484b.
    
    * Bring back the removed `checksum`, `nooptcheck` and `ignorefsmerr` flags
    
    * Define a bunch of interfaces and don't export any new structs from `tap/api`
    
    * Keep the interfaces in `tap/api` but move the structs to `tap/tcp`
    
    * Fix the unit tests by depending on `github.com/up9inc/mizu/tap`
    
    * Use the modified `tlsEmitter`
    
    * Define `TlsChunk` interface and make `tlsReader` implement `TcpReader`
    
    * Remove unused fields in `tlsReader`
    
    * Define `ReassemblyStream` interface and separate `gopacket` specififc fields to `tcpReassemblyStream` struct
    
    Such that make `tap/api` don't depend on `gopacket`
    
    * Remove the unused fields
    
    * Make `tlsPoller` implement `TcpStream` interface and remove the call to `NewTcpStreamDummy` method
    
    * Remove unused fields from `tlsPoller`
    
    * Remove almost all of the setter methods in `TcpReader` and `TcpStream` interface and remove `TlsChunk` interface
    
    * Revert "Revert "Remove `GOGC` environment variable from tapper""
    
    This reverts commit ab2b9a80.
    
    * Revert "Bring back `debug.FreeOSMemory()` call"
    
    This reverts commit 1cce863b.
    
    * Remove excess comment
    
    * Fix acceptance tests (`logger` module) #run_acceptance_tests
    
    * Bring back `github.com/patrickmn/go-cache`
    
    * Fix `NewTcpStream` method signature
    
    * Put `tcpReader` and `tcpStream` mocks into protocol dissectors to remove `github.com/up9inc/mizu/tap` dependency
    
    * Fix AMQP tests
    
    * Revert 960ba644
    
    * Revert `go.mod` and `go.sum` files in protocol dissectors
    
    * Fix the comment position
    
    * Revert `AppStatsInst` change
    
    * Fix indent
    
    * Fix CLI build
    
    * Fix linter error
    
    * Fix error msg
    
    * Revert some of the changes in `chunk.go`
    d3e6a69d