feat: DAT:3414 changed /cliIds/:cliId to x-cli-id header (#151)

* feat: changed /cliIds/:cliId to x-cli-id header

* fix: changed tag to staging in makefile

* refactor: changed headers to map literal

* refactor: changed map literal in test
Co-authored-by: Roy Hadad <roy@datree.io>

pkg/cliClient/cliClient_test.go

@@ -438,6 +438,8 @@ func test_createEvaluation_success() *CreateEvaluationTestCase {
 }
 
 func test_publishPolicies_success() *PublishPoliciesTestCase {
+	expectedPublishHeaders := map[string]string{"x-cli-id": "cli_id"}
+
 	requestPoliciesConfigurationArg := files.UnknownStruct{}
 	return &PublishPoliciesTestCase{
 		name: "success - publish policies",
@@ -479,9 +481,9 @@ func test_publishPolicies_success() *PublishPoliciesTestCase {
 				headers map[string]string
 			}{
 				method:  http.MethodPut,
-				uri:     "/cli/policy/publish/cliIds/cli_id",
+				uri:     "/cli/policy/publish",
 				body:    requestPoliciesConfigurationArg,
-				headers: nil,
+				headers: expectedPublishHeaders,
 			},
 			response: nil,
 		},
@@ -489,6 +491,8 @@ func test_publishPolicies_success() *PublishPoliciesTestCase {
 }
 
 func test_publishPolicies_schemaError() *PublishPoliciesTestCase {
+	expectedPublishHeaders := map[string]string{"x-cli-id": "cli_id"}
+
 	requestPoliciesConfigurationArg := files.UnknownStruct{}
 	return &PublishPoliciesTestCase{
 		name: "schema error - publish policies",
@@ -530,9 +534,9 @@ func test_publishPolicies_schemaError() *PublishPoliciesTestCase {
 				headers map[string]string
 			}{
 				method:  http.MethodPut,
-				uri:     "/cli/policy/publish/cliIds/cli_id",
+				uri:     "/cli/policy/publish",
 				body:    requestPoliciesConfigurationArg,
-				headers: nil,
+				headers: expectedPublishHeaders,
 			},
 			response: errors.New("error from cli-service"),
 		},

pkg/cliClient/publish.go

@@ -6,6 +6,7 @@ import (
 )
 
 func (c *CliClient) PublishPolicies(policiesConfiguration files.UnknownStruct, cliId string) error {
-	_, err := c.httpClient.Request(http.MethodPut, "/cli/policy/publish/cliIds/"+cliId, policiesConfiguration, nil)
+	headers := map[string]string{"x-cli-id": cliId}
+	_, err := c.httpClient.Request(http.MethodPut, "/cli/policy/publish", policiesConfiguration, headers)
 	return err
 }