fix lint issues

iso/scripts/generate_docker_images.sh

 #!/bin/bash
 
+# shellcheck disable=SC1091
 source /usr/src/app/.dappnode_profile
 
 echo "Cleaning previous files"
@@ -8,27 +9,27 @@ rm -rf ./DNP_*
 echo "Cloning & building DNP_HTTPS..."
 git clone -b "v${HTTPS_VERSION}" https://github.com/dappnode/DNP_HTTPS
 docker-compose -f ./DNP_HTTPS/docker-compose-https.yml build
-docker save https.dnp.dappnode.eth:${HTTPS_VERSION} | xz -e9vT0 >/images/https.dnp.dappnode.eth_${HTTPS_VERSION}_linux-amd64.txz
+docker save https.dnp.dappnode.eth:"$HTTPS_VERSION" | xz -e9vT0 >/images/https.dnp.dappnode.eth_"$HTTPS_VERSION"_linux-amd64.txz
 
 echo "Cloning & building DNP_WIREGUARD..."
 git clone -b "v${WIREGUARD_VERSION}" https://github.com/dappnode/DNP_WIREGUARD
 docker-compose -f ./DNP_WIREGUARD/docker-compose-wireguard.yml build
-docker save wireguard.dnp.dappnode.eth:${WIREGUARD_VERSION} | xz -e9vT0 >/images/wireguard.dnp.dappnode.eth_${WIREGUARD_VERSION}_linux-amd64.txz
+docker save wireguard.dnp.dappnode.eth:"$WIREGUARD_VERSION" | xz -e9vT0 >/images/wireguard.dnp.dappnode.eth_"$WIREGUARD_VERSION"_linux-amd64.txz
 
 echo "Cloning & building DNP_IPFS..."
 git clone -b "v${IPFS_VERSION}" https://github.com/dappnode/DNP_IPFS
 docker-compose -f ./DNP_IPFS/docker-compose-ipfs.yml build
-docker save ipfs.dnp.dappnode.eth:${IPFS_VERSION} | xz -e9vT0 >/images/ipfs.dnp.dappnode.eth_${IPFS_VERSION}_linux-amd64.txz
+docker save ipfs.dnp.dappnode.eth:"$IPFS_VERSION" | xz -e9vT0 >/images/ipfs.dnp.dappnode.eth_"$IPFS_VERSION"_linux-amd64.txz
 
 echo "Cloning & building DNP_BIND..."
 git clone -b "v${BIND_VERSION}" https://github.com/dappnode/DNP_BIND
 docker-compose -f ./DNP_BIND/docker-compose-bind.yml build
-docker save bind.dnp.dappnode.eth:${BIND_VERSION} | xz -e9vT0 >/images/bind.dnp.dappnode.eth_${BIND_VERSION}_linux-amd64.txz
+docker save bind.dnp.dappnode.eth:"$BIND_VERSION" | xz -e9vT0 >/images/bind.dnp.dappnode.eth_"$BIND_VERSION"_linux-amd64.txz
 
 echo "Cloning & building DNP_DAPPMANAGER..."
 git clone -b "v${DAPPMANAGER_VERSION}" https://github.com/dappnode/DNP_DAPPMANAGER
 docker-compose -f ./DNP_DAPPMANAGER/docker-compose-dappmanager.yml build
-docker save dappmanager.dnp.dappnode.eth:${DAPPMANAGER_VERSION} | xz -e9vT0 >/images/dappmanager.dnp.dappnode.eth_${DAPPMANAGER_VERSION}_linux-amd64.txz
+docker save dappmanager.dnp.dappnode.eth:"$DAPPMANAGER_VERSION" | xz -e9vT0 >/images/dappmanager.dnp.dappnode.eth_"$DAPPMANAGER_VERSION"_linux-amd64.txz
 
 echo "Coping dappnode_all_docker_images_linux-amd64.txz to dappnode dir..."
 cp /images/* /usr/src/app/dappnode/

iso/scripts/prepare_snapshot.sh

@@ -11,7 +11,7 @@ wget -qO - https://prerequisites.dappnode.io  | sudo bash
 
 mkdir -p /usr/src/dappnode/scripts/
 
-wget $DAPPNODE_INSTALL_SCRIPT_URL -O /usr/src/dappnode/scripts/dappnode_install.sh
+wget "$DAPPNODE_INSTALL_SCRIPT_URL" -O /usr/src/dappnode/scripts/dappnode_install.sh
 
 chmod +x /usr/src/dappnode/scripts/dappnode_install.sh
 

scripts/check-disks.sh

@@ -11,5 +11,5 @@ fi
 for DISK in ${DEVICE}; do
     DISKS="${DISKS} ${DISK}";
 done;
-DISKS=$(echo ${DISKS} | sed "s/^ //g");
+DISKS=$(echo "${DISKS}" | sed "s/^ //g");
 debconf-set partman-auto/disk "$DISKS"; 
\ No newline at end of file

scripts/dappnode_test_install.sh

@@ -58,7 +58,8 @@ echo -e "\e[32m doing docker image integrity test...\e[0m"
 imgs=$(docker images | grep dappnode | awk '{print $3}')
 
 for img in $imgs; do
-    docker save $img >/dev/null && echo -ne "\e[32mImage $img OK\n\e[0m" || echo "\e[31mImage $img Corrupted!\n\e[0m"
+    # shellcheck disable=SC2028
+    docker save "$img" >/dev/null && echo -ne "\e[32mImage $img OK\n\e[0m" || echo "\e[31mImage $img Corrupted!\n\e[0m"
 done
 
 rm -f /usr/src/dappnode/.firstboot

scripts/static_ip.sh

 #!/bin/sh
 # This is a debconf-compatible script
+# shellcheck disable=SC1091
 . /usr/share/debconf/confmodule
 
 valid_ip () {
@@ -11,7 +12,7 @@ valid_ip () {
 
     if expr "$ip" : '[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*$' >/dev/null; then
         for i in 1 2 3 4; do
-            if [ $(echo "$ip" | cut -d. -f$i) -gt 255 ]; then
+            if [ "$(echo "$ip" | cut -d. -f$i)" -gt 255 ]; then
                 return 1
             fi
         done
@@ -54,7 +55,7 @@ db_dialog () {
     db_go
     db_get ip-question/ask
 
-    valid_ip $RET
+    valid_ip "$RET"
     if [[ $? -eq 0 ]]; then
         mkdir -p /target/usr/src/dappnode/config
         echo "$RET" > /target/usr/src/dappnode/config/static_ip